Attachment 40045 Details for Bug 31339 – Patch to always reset validity entries in reused router structure instead of just for connectors with attached router objects

[patch] Patch to always reset validity entries in reused router structure instead of just for connectors with attached router objects

0001-drm-radeon-kms-always-reset-validity-of-reused-route.patch (text/plain), 1.90 KB, created by Tyson Whitehead on 2010-11-04 09:24:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tyson Whitehead

Created: 2010-11-04 09:24:45 UTC

Size: 1.90 KB

patch

obsolete

>From 0b08b00350b29d6503bc1b11d8a61c5d8e5c7a29 Mon Sep 17 00:00:00 2001
>From: Tyson Whitehead <twhitehead@gmail.com>
>Date: Thu, 4 Nov 2010 12:08:14 -0400
>Subject: [PATCH] drm/radeon/kms: always reset validity of reused router structure
>
>This patch moves the initialization of the validity entries for the
>router structure so they are reset on every connector object
>instead of just those with router objects attached.
>---
> drivers/gpu/drm/radeon/radeon_atombios.c |    7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
>index 9bedf1c..07fb641 100644
>--- a/drivers/gpu/drm/radeon/radeon_atombios.c
>+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
>@@ -526,9 +526,6 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev)
> 	if (crev < 2)
> 		return false;
> 
>-	router.ddc_valid = false;
>-	router.cd_valid = false;
>-
> 	obj_header = (ATOM_OBJECT_HEADER *) (ctx->bios + data_offset);
> 	path_obj = (ATOM_DISPLAY_OBJECT_PATH_TABLE *)
> 	    (ctx->bios + data_offset +
>@@ -625,6 +622,8 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev)
> 			if (connector_type == DRM_MODE_CONNECTOR_Unknown)
> 				continue;
> 
>+                        router.ddc_valid = false;
>+                        router.cd_valid = false;
> 			for (j = 0; j < ((le16_to_cpu(path->usSize) - 8) / 2); j++) {
> 				uint8_t grph_obj_id, grph_obj_num, grph_obj_type;
> 
>@@ -648,8 +647,6 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev)
> 								 usDeviceTag));
> 
> 				} else if (grph_obj_type == GRAPH_OBJECT_TYPE_ROUTER) {
>-					router.ddc_valid = false;
>-					router.cd_valid = false;
> 					for (k = 0; k < router_obj->ucNumberOfObjects; k++) {
> 						u16 router_obj_id = le16_to_cpu(router_obj->asObjects[k].usObjectID);
> 						if (le16_to_cpu(path->usGraphicObjIds[j]) == router_obj_id) {
>-- 
>1.7.3.1
>

Actions: View | Splinter Review

Attachments on bug 31339: 39993 | 39994 | 39997 | 39998 | 39999 | 40000 | 40002 | 40003 | 40015 | 40017 | 40045 | 40073 | 40110

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.