Attachment 40073 Details for Bug 31339 – Patch to add (likely) missing complements in masking operations used to update DDC and clock/data mux

[patch] Patch to add (likely) missing complements in masking operations used to update DDC and clock/data mux

0001-drm-radeon-kms-fix-missing-complement-for-i2c-mux-co.patch (text/plain), 2.23 KB, created by Tyson Whitehead on 2010-11-05 11:43:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tyson Whitehead

Created: 2010-11-05 11:43:10 UTC

Size: 2.23 KB

patch

obsolete

>From a3b11af8c74142c4125da45a4b02278d6f0d2d83 Mon Sep 17 00:00:00 2001
>From: Tyson Whitehead <twhitehead@gmail.com>
>Date: Fri, 5 Nov 2010 14:22:03 -0400
>Subject: [PATCH] drm/radeon/kms: fix missing complement for i2c mux control mask
>
>This patch fixes the masking operation used to update the mux
>control bits (DDC and clock/data routers).
>---
> drivers/gpu/drm/radeon/radeon_i2c.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
>index 24b8a8b..0cfbba0 100644
>--- a/drivers/gpu/drm/radeon/radeon_i2c.c
>+++ b/drivers/gpu/drm/radeon/radeon_i2c.c
>@@ -1095,14 +1095,14 @@ void radeon_router_select_ddc_port(struct radeon_connector *radeon_connector)
> 	radeon_i2c_get_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x3, &val);
>-	val &= radeon_connector->router.ddc_mux_control_pin;
>+	val &= ~radeon_connector->router.ddc_mux_control_pin;
> 	radeon_i2c_put_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x3, val);
> 	radeon_i2c_get_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x1, &val);
>-	val &= radeon_connector->router.ddc_mux_control_pin;
>+	val &= ~radeon_connector->router.ddc_mux_control_pin;
> 	val |= radeon_connector->router.ddc_mux_state;
> 	radeon_i2c_put_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
>@@ -1120,14 +1120,14 @@ void radeon_router_select_cd_port(struct radeon_connector *radeon_connector)
> 	radeon_i2c_get_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x3, &val);
>-	val &= radeon_connector->router.cd_mux_control_pin;
>+	val &= ~radeon_connector->router.cd_mux_control_pin;
> 	radeon_i2c_put_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x3, val);
> 	radeon_i2c_get_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
> 			    0x1, &val);
>-	val &= radeon_connector->router.cd_mux_control_pin;
>+	val &= ~radeon_connector->router.cd_mux_control_pin;
> 	val |= radeon_connector->router.cd_mux_state;
> 	radeon_i2c_put_byte(radeon_connector->router_bus,
> 			    radeon_connector->router.i2c_addr,
>-- 
>1.7.3.1
>

Actions: View | Splinter Review

Attachments on bug 31339: 39993 | 39994 | 39997 | 39998 | 39999 | 40000 | 40002 | 40003 | 40015 | 40017 | 40045 | 40073 | 40110

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.