Attachment 40547 Details for Bug 31512 – allocate at least 1 page in doc->pages

[patch] allocate at least 1 page in doc->pages

0001-Allocate-at-least-1-page-in-doc-pages.patch (text/plain), 1.13 KB, created by Marek Kasik on 2010-11-24 06:56:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marek Kasik

Created: 2010-11-24 06:56:29 UTC

Size: 1.13 KB

patch

obsolete

>From 8e49adab5471bc8029fa2aa792915490de26d00d Mon Sep 17 00:00:00 2001
>From: Marek Kasik <mkasik@redhat.com>
>Date: Wed, 24 Nov 2010 15:54:14 +0100
>Subject: [PATCH] Allocate at least 1 page in doc->pages
>
>Allocate at least 1 page if there are no %%Pages: or %%Page: comments
>in the PS file (#31512).
>---
> libspectre/ps.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/libspectre/ps.c b/libspectre/ps.c
>index 4578cec..0130fb4 100644
>--- a/libspectre/ps.c
>+++ b/libspectre/ps.c
>@@ -1004,14 +1004,14 @@ psscan(const char *filename, int scanstyle)
> 	section_len += line_len;
>     }
> 
>+    if (maxpages == 0) {
>+	maxpages = 1;
>+	doc->pages = (struct page *) PS_calloc(maxpages, sizeof(struct page));
>+	CHECK_MALLOCED(doc->pages);
>+    }
> 
> newpage:
>     while (DSCcomment(line) && iscomment(line+2, "Page:")) {
>-	if (maxpages == 0) {
>-	    maxpages = 1;
>-	    doc->pages = (struct page *) PS_calloc(maxpages, sizeof(struct page));
>-            CHECK_MALLOCED(doc->pages);
>-	}
> 	label = ps_gettext(line+length("%%Page:"), &next_char);
> 	if (sscanf(next_char, "%u", &thispage) != 1) thispage = 0;
> 	if (nextpage == 1) {
>-- 
>1.7.3.2
>

Actions: View | Splinter Review

Attachments on bug 31512: 40165 | 40547

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.