Attachment 40637 Details for Bug 31942 – Disable pfitter for 1:1 scaling

[patch] Disable pfitter for 1:1 scaling

0001-drm-i915-lvds-Disable-panel-fitter-on-gen4-for-1-1-s.patch (text/plain), 1.61 KB, created by Chris Wilson on 2010-11-29 08:21:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-11-29 08:21:30 UTC

Size: 1.61 KB

patch

obsolete

>From ceb3cdb3aa0d7d026e85e81f3265bc48795d28df Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 29 Nov 2010 16:19:24 +0000
>Subject: [PATCH] drm/i915/lvds: Disable panel-fitter on gen4 for 1:1 scale factors
>
>Relying on the hardware to do the right thing? I was mad.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=31942
>Reported-by: Ben Kohler <bkohler@gmail.com>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_lvds.c |    9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
>index 4324a32..26df4b7 100644
>--- a/drivers/gpu/drm/i915/intel_lvds.c
>+++ b/drivers/gpu/drm/i915/intel_lvds.c
>@@ -269,14 +269,13 @@ static bool intel_lvds_mode_fixup(struct drm_encoder *encoder,
> 			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
> 			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
> 
>-			pfit_control |= PFIT_ENABLE;
> 			/* 965+ is easy, it does everything in hw */
> 			if (scaled_width > scaled_height)
>-				pfit_control |= PFIT_SCALING_PILLAR;
>+				pfit_control |= PFIT_ENABLE | PFIT_SCALING_PILLAR;
> 			else if (scaled_width < scaled_height)
>-				pfit_control |= PFIT_SCALING_LETTER;
>-			else
>-				pfit_control |= PFIT_SCALING_AUTO;
>+				pfit_control |= PFIT_ENABLE | PFIT_SCALING_LETTER;
>+			else if (adjusted_mode->hdisplay != mode->hdisplay)
>+				pfit_control |= PFIT_ENABLE | PFIT_SCALING_AUTO;
> 		} else {
> 			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
> 			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 31942: 40616 | 40618 | 40619 | 40637 | 40640 | 40642 | 40643

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.