Attachment 41594 Details for Bug 32732 – revert hpd pin swap

[patch] revert hpd pin swap

0001-drm-radeon-kms-partially-revert-acer-laptop-quirk.patch (text/plain), 1.86 KB, created by Alex Deucher on 2011-01-03 09:47:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-01-03 09:47:30 UTC

Size: 1.86 KB

patch

obsolete

>From 2ddbbbd118c098aec6e37ad5d432c9c0ad8c97c2 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Mon, 3 Jan 2011 12:43:04 -0500
>Subject: [PATCH] drm/radeon/kms: partially revert acer laptop quirk
>
>hpd pins may not be swapped after all.
>
>may fix:
>https://bugs.freedesktop.org/show_bug.cgi?id=32732
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/radeon/radeon_atombios.c |   11 +----------
> 1 files changed, 1 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
>index 55a0846..fcb3257 100644
>--- a/drivers/gpu/drm/radeon/radeon_atombios.c
>+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
>@@ -313,7 +313,6 @@ static bool radeon_atom_apply_quirks(struct drm_device *dev,
> 				     uint16_t *line_mux,
> 				     struct radeon_hpd *hpd)
> {
>-	struct radeon_device *rdev = dev->dev_private;
> 
> 	/* Asus M2A-VM HDMI board lists the DVI port as HDMI */
> 	if ((dev->pdev->device == 0x791e) &&
>@@ -436,21 +435,13 @@ static bool radeon_atom_apply_quirks(struct drm_device *dev,
> 		}
> 	}
> 
>-	/* Acer laptop reports DVI-D as DVI-I and hpd pins reversed */
>+	/* Acer laptop reports DVI-D as DVI-I */
> 	if ((dev->pdev->device == 0x95c4) &&
> 	    (dev->pdev->subsystem_vendor == 0x1025) &&
> 	    (dev->pdev->subsystem_device == 0x013c)) {
>-		struct radeon_gpio_rec gpio;
>-
> 		if ((*connector_type == DRM_MODE_CONNECTOR_DVII) &&
> 		    (supported_device == ATOM_DEVICE_DFP1_SUPPORT)) {
>-			gpio = radeon_lookup_gpio(rdev, 6);
>-			*hpd = radeon_atom_get_hpd_info_from_gpio(rdev, &gpio);
> 			*connector_type = DRM_MODE_CONNECTOR_DVID;
>-		} else if ((*connector_type == DRM_MODE_CONNECTOR_HDMIA) &&
>-			   (supported_device == ATOM_DEVICE_DFP1_SUPPORT)) {
>-			gpio = radeon_lookup_gpio(rdev, 7);
>-			*hpd = radeon_atom_get_hpd_info_from_gpio(rdev, &gpio);
> 		}
> 	}
> 
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 32732: 41509 | 41510 | 41511 | 41514 | 41594 | 41648

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.