Attachment 41622 Details for Bug 29884 – Get member name from the method call message, not the reply, for warnings

[patch] Get member name from the method call message, not the reply, for warnings

0001-Get-member-name-from-the-method-call-message-not-the.patch (text/plain), 990 bytes, created by Simon McVittie on 2011-01-04 07:30:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-01-04 07:30:46 UTC

Size: 990 bytes

patch

obsolete

>From 9e317751a48a6c5b6cfb5b38510156af4b6ccd8f Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 4 Jan 2011 14:27:32 +0000
>Subject: [PATCH] Get member name from the method call message, not the reply, for warnings
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29884
>---
> dbus/dbus-gobject.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/dbus/dbus-gobject.c b/dbus/dbus-gobject.c
>index b069f52..032f009 100644
>--- a/dbus/dbus-gobject.c
>+++ b/dbus/dbus-gobject.c
>@@ -2947,7 +2947,8 @@ dbus_g_method_return (DBusGMethodInvocation *context, ...)
>         {
>           if (!_dbus_gvalue_marshal (&iter, &value))
>             g_warning ("failed to marshal parameter %d for method %s",
>-                       i, dbus_message_get_member (reply));
>+                       i, dbus_message_get_member (
>+                         dbus_g_message_get_message (context->message)));
>         }
>     }
>   va_end (args);
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 29884: 38288 | 38289 | 38290 | 41068 | 41069 | 41622

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.