Attachment 42172 Details for Bug 33126 – [7/7] _dbus_transport_get_is_authenticated: don't leak if copying GUID fails

[patch] [7/7] _dbus_transport_get_is_authenticated: don't leak if copying GUID fails

0007-_dbus_transport_get_is_authenticated-don-t-leak-if-c.patch (text/plain), 1.10 KB, created by Simon McVittie on 2011-01-18 08:58:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-01-18 08:58:50 UTC

Size: 1.10 KB

patch

obsolete

>From 1b170a4385eec374386e4e3b273b72b9ee0b773c Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 18 Jan 2011 15:32:36 +0000
>Subject: [PATCH 7/7] _dbus_transport_get_is_authenticated: don't leak if copying GUID fails
>
>This would fail the "SHA1 connection test" if _dbus_iterate is modified
>to allocate and free one extra pointer per iteration.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33126
>---
> dbus/dbus-transport.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/dbus/dbus-transport.c b/dbus/dbus-transport.c
>index a078f7c..d899cfd 100644
>--- a/dbus/dbus-transport.c
>+++ b/dbus/dbus-transport.c
>@@ -749,6 +749,8 @@ _dbus_transport_get_is_authenticated (DBusTransport *transport)
>               if (transport->expected_guid == NULL)
>                 {
>                   _dbus_verbose ("No memory to complete auth\n");
>+                  /* FIXME: should we disconnect the transport, too? */
>+                  _dbus_connection_unref_unlocked (transport->connection);
>                   return FALSE;
>                 }
>             }
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 33126: 42042 | 42043 | 42044 | 42045 | 42046 | 42168 | 42169 | 42170 | 42171 | 42172 | 42807 | 42808 | 42809

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.