Attachment 42543 Details for Bug 33128 – dbus_connection_dispatch: remove dead code

[patch] dbus_connection_dispatch: remove dead code

0001-dbus_connection_dispatch-remove-dead-code.patch (text/plain), 1.14 KB, created by Simon McVittie on 2011-01-26 10:42:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-01-26 10:42:40 UTC

Size: 1.14 KB

patch

obsolete

>From f6194e3407f420ff1f7e81f61f2d42ee7d1fdac1 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 26 Jan 2011 18:38:01 +0000
>Subject: [PATCH 1/2] dbus_connection_dispatch: remove dead code
>
>There's no way pending can be non-NULL here; if it was, we'd have jumped
>straight past this block (getting filters from the connection), because
>replies to pending calls don't go through filters.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128
>---
> dbus/dbus-connection.c |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
>diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
>index 6779b6a..dfe5222 100644
>--- a/dbus/dbus-connection.c
>+++ b/dbus/dbus-connection.c
>@@ -4613,9 +4613,6 @@ dbus_connection_dispatch (DBusConnection *connection)
>       /* unlocks and calls user code */
>       _dbus_connection_update_dispatch_status_and_unlock (connection,
>                                                           DBUS_DISPATCH_NEED_MEMORY);
>-
>-      if (pending)
>-        dbus_pending_call_unref (pending);
>       dbus_connection_unref (connection);
>       
>       return DBUS_DISPATCH_NEED_MEMORY;
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 33128: 42049 | 42050 | 42051 | 42053 | 42054 | 42055 | 42056 | 42057 | 42058 | 42059 | 42060 | 42061 | 42543 | 42544

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.