Attachment 4269 Details for Bug 5276 – Proposed fix

[patch] Proposed fix

birnan (text/plain), 1.09 KB, created by Søren Sandmann Pedersen on 2006-01-07 09:21:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Søren Sandmann Pedersen

Created: 2006-01-07 09:21:12 UTC

Size: 1.09 KB

patch

obsolete

>? birnan
>Index: mivaltree.c
>===================================================================
>RCS file: /cvs/xorg/xserver/xorg/mi/mivaltree.c,v
>retrieving revision 1.6
>diff -u -p -u -r1.6 mivaltree.c
>--- mivaltree.c	3 Jul 2005 07:01:51 -0000	1.6
>+++ mivaltree.c	6 Jan 2006 21:29:57 -0000
>@@ -313,7 +313,11 @@ miComputeClips (
> 	    {
> 		if (pChild->viewable)
> 		{
>-		    if (pChild->visibility != VisibilityFullyObscured)
>+		    if (pChild->visibility != VisibilityFullyObscured
>+#ifdef COMPOSITE
>+			|| pChild->redirectDraw
>+#endif
>+			)
> 		    {
> 			REGION_TRANSLATE( pScreen, &pChild->borderClip,
> 						      dx, dy);
>@@ -493,7 +497,14 @@ miComputeClips (
>      * new, just as for the border.
>      */
> 
>-    if (oldVis == VisibilityFullyObscured ||
>+    /* For composite this optimization is incorrect since
>+     * the window should not in fact be exposed just because it
>+     * was FullyObscured before.
>+     */
>+    if (
>+#ifndef COMPOSITE
>+    oldVis == VisibilityFullyObscured ||
>+#endif
> 	oldVis == VisibilityNotViewable)
>     {
> 	REGION_COPY( pScreen, &pParent->valdata->after.exposed, universe);

Actions: View | Splinter Review

Attachments on bug 5276: 4038 | 4269 | 4944

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.