Attachment 42764 Details for Bug 33757 – [3/3] bus_driver_generate_introspect_string: don't hard-code Introspect()

[patch] [3/3] bus_driver_generate_introspect_string: don't hard-code Introspect()

0003-bus_driver_generate_introspect_string-don-t-hard-cod.patch (text/plain), 1.27 KB, created by Simon McVittie on 2011-01-31 10:52:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-01-31 10:52:53 UTC

Size: 1.27 KB

patch

obsolete

>From f92a012b86980e66c2a78b07afbd047a66937d9e Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 31 Jan 2011 18:49:19 +0000
>Subject: [PATCH 3/3] bus_driver_generate_introspect_string: don't hard-code Introspect()
>
>Introspectable is now just an interface like any other, so we don't
>need to hard-code it.
>---
> bus/driver.c |   10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
>diff --git a/bus/driver.c b/bus/driver.c
>index 102bfa7..1e9573e 100644
>--- a/bus/driver.c
>+++ b/bus/driver.c
>@@ -1813,16 +1813,6 @@ bus_driver_generate_introspect_string (DBusString *xml)
>     return FALSE;
>   if (!_dbus_string_append (xml, "<node>\n"))
>     return FALSE;
>-  if (!_dbus_string_append_printf (xml, "  <interface name=\"%s\">\n", DBUS_INTERFACE_INTROSPECTABLE))
>-    return FALSE;
>-  if (!_dbus_string_append (xml, "    <method name=\"Introspect\">\n"))
>-    return FALSE;
>-  if (!_dbus_string_append_printf (xml, "      <arg name=\"data\" direction=\"out\" type=\"%s\"/>\n", DBUS_TYPE_STRING_AS_STRING))
>-    return FALSE;
>-  if (!_dbus_string_append (xml, "    </method>\n"))
>-    return FALSE;
>-  if (!_dbus_string_append (xml, "  </interface>\n"))
>-    return FALSE;
> 
>   for (ih = interface_handlers; ih->name != NULL; ih++)
>     {
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 33757: 42749 | 42763 | 42764

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.