Attachment 43233 Details for Bug 34123 – possible fix

[patch] possible fix

0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real.patch (text/plain), 2.66 KB, created by Alex Deucher on 2011-02-10 23:46:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-02-10 23:46:49 UTC

Size: 2.66 KB

patch

obsolete

>From e1c5703223d21441bcbdd222572e592984e5ae10 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Fri, 11 Feb 2011 02:25:51 -0500
>Subject: [PATCH] drm/radeon/kms: hopefully fix pll issues for real
>
>The problematic boards have a recommended reference divider
>to be used when spread spectrum is enabled on the laptop panel.
>Enable the use of the recommended reference divider along with
>the new pll algo.  This should hopefully fix the issues across
>the board.
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/radeon/atombios_crtc.c |   18 +++++-------------
> 1 files changed, 5 insertions(+), 13 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
>index dd4e3ac..638f926 100644
>--- a/drivers/gpu/drm/radeon/atombios_crtc.c
>+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
>@@ -555,8 +555,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
> 					dp_clock = dig_connector->dp_clock;
> 				}
> 			}
>-/* this might work properly with the new pll algo */
>-#if 0 /* doesn't work properly on some laptops */
>+
> 			/* use recommended ref_div for ss */
> 			if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
> 				if (ss_enabled) {
>@@ -566,18 +565,15 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
> 					}
> 				}
> 			}
>-#endif
>+
> 			if (ASIC_IS_AVIVO(rdev)) {
> 				/* DVO wants 2x pixel clock if the DVO chip is in 12 bit mode */
> 				if (radeon_encoder->encoder_id == ENCODER_OBJECT_ID_INTERNAL_KLDSCP_DVO1)
> 					adjusted_clock = mode->clock * 2;
> 				if (radeon_encoder->active_device & (ATOM_DEVICE_TV_SUPPORT))
> 					pll->flags |= RADEON_PLL_PREFER_CLOSEST_LOWER;
>-				/* rv515 needs more testing with this option */
>-				if (rdev->family != CHIP_RV515) {
>-					if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT))
>-						pll->flags |= RADEON_PLL_IS_LCD;
>-				}
>+				if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT))
>+					pll->flags |= RADEON_PLL_IS_LCD;
> 			} else {
> 				if (encoder->encoder_type != DRM_MODE_ENCODER_DAC)
> 					pll->flags |= RADEON_PLL_NO_ODD_POST_DIV;
>@@ -957,11 +953,7 @@ static void atombios_crtc_set_pll(struct drm_crtc *crtc, struct drm_display_mode
> 	/* adjust pixel clock as needed */
> 	adjusted_clock = atombios_adjust_pll(crtc, mode, pll, ss_enabled, &ss);
> 
>-	/* rv515 seems happier with the old algo */
>-	if (rdev->family == CHIP_RV515)
>-		radeon_compute_pll_legacy(pll, adjusted_clock, &pll_clock, &fb_div, &frac_fb_div,
>-					  &ref_div, &post_div);
>-	else if (ASIC_IS_AVIVO(rdev))
>+	if (ASIC_IS_AVIVO(rdev))
> 		radeon_compute_pll_avivo(pll, adjusted_clock, &pll_clock, &fb_div, &frac_fb_div,
> 					 &ref_div, &post_div);
> 	else
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 34123: 43190 | 43191 | 43226 | 43233

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.