Attachment 43360 Details for Bug 6923 – Patch fixing the issue

[patch] Patch fixing the issue

0001-TextOutputDev-Break-words-when-FontInfo-changes.patch (text/plain), 1.27 KB, created by Jose Aliste on 2011-02-14 18:24:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jose Aliste

Created: 2011-02-14 18:24:06 UTC

Size: 1.27 KB

patch

obsolete

>From 4cc15f9e1a14e8799882d50a432769d52a63410b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Jos=C3=A9=20Aliste?= <jaliste@src.gnome.org>
>Date: Mon, 14 Feb 2011 23:13:59 -0300
>Subject: [PATCH] TextOutputDev: Break words when FontInfo changes.
>
>See bug #6923.
>---
> poppler/TextOutputDev.cc |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/poppler/TextOutputDev.cc b/poppler/TextOutputDev.cc
>index 71b946e..8693fe7 100644
>--- a/poppler/TextOutputDev.cc
>+++ b/poppler/TextOutputDev.cc
>@@ -2208,6 +2208,7 @@ void TextPage::addChar(GfxState *state, double x, double y,
>   // (3) the previous character was an overlap (we want each duplicated
>   //     character to be in a word by itself at this stage),
>   // (4) the font size has changed
>+  // (5) the font info has changed
>   if (curWord && curWord->len > 0) {
>     base = sp = delta = 0; // make gcc happy
>     switch (curWord->rot) {
>@@ -2238,7 +2239,8 @@ void TextPage::addChar(GfxState *state, double x, double y,
> 	sp < -minDupBreakOverlap * curWord->fontSize ||
> 	sp > minWordBreakSpace * curWord->fontSize ||
> 	fabs(base - curWord->base) > 0.5 ||
>-	curFontSize != curWord->fontSize) {
>+	curFontSize != curWord->fontSize ||
>+	curFont != curWord->font) {
>       endWord();
>     }
>     lastCharOverlap = overlap;
>-- 
>1.7.3.5
>

Actions: View | Splinter Review

Attachments on bug 6923: 18147 | 43360 | 43420 | 43421 | 43455 | 65449 | 65992 | 66101 | 66163 | 66375 | 66450 | 66454 | 104775 | 104776

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.