Attachment 43614 Details for Bug 33466 – Add support for --disable-gc-sections for broken toolchains (v2)

[patch] Add support for --disable-gc-sections for broken toolchains (v2)

0001-Add-support-for-disable-gc-sections-for-broken-toolc.patch (text/plain), 3.09 KB, created by Simon McVittie on 2011-02-21 09:20:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-02-21 09:20:45 UTC

Size: 3.09 KB

patch

obsolete

>From 628a634d5fc32f63c69eba8eadcfca60d390f5c2 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 21 Feb 2011 17:13:12 +0000
>Subject: [PATCH] Add support for --disable-gc-sections for broken toolchains
>
>Also use AC_LINK_IFELSE rather than reinventing it as a shell function.
>This was the last user of ld_supports_flag, so, delete it.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33466
>---
> configure.in |   62 ++++++++++++++++++++++++---------------------------------
> 1 files changed, 26 insertions(+), 36 deletions(-)
>
>diff --git a/configure.in b/configure.in
>index 3b48f45..e27f0e6 100644
>--- a/configure.in
>+++ b/configure.in
>@@ -1092,36 +1092,6 @@ cc_supports_flag() {
>   test "x$rc" = xyes
> }
> 
>-ld_supports_flag() {
>-  AC_MSG_CHECKING([whether $LD supports "$@"])
>-  AC_TRY_LINK([
>-    int one(void) { return 1; }
>-    int two(void) { return 2; }
>-  ], [ two(); ] , [_ac_ld_flag_supported=yes], [_ac_ld_flag_supported=no])
>-
>-  if test "$_ac_ld_flag_supported" = "yes"; then
>-    rm -f conftest.c
>-    touch conftest.c
>-    if $CC -c conftest.c; then
>-      ld_out=`$LD $@ -o conftest conftest.o 2>&1`
>-      ld_ret=$?
>-      if test $ld_ret -ne 0 ; then
>-        _ac_ld_flag_supported=no
>-      elif echo "$ld_out" | egrep 'option ignored|^usage:|unrecognized option|illegal option' >/dev/null ; then
>-        _ac_ld_flag_supported=no
>-      fi
>-    fi
>-    rm -f conftest.c conftest.o conftest
>-  fi
>-
>-  AC_MSG_RESULT($_ac_ld_flag_supported)
>-  if test "$_ac_ld_flag_supported" = "yes" ; then
>-    return 0
>-  else
>-    return 1
>-  fi
>-}
>-
> # Don't bother with -Werror on Windows for now, too many warnings
> if test x$dbus_win != xyes -a x$dbus_cygwin != xyes -a x$USE_MAINTAINER_MODE = xyes; then
>   if cc_supports_flag "-Werror"; then
>@@ -1251,13 +1221,33 @@ if test "x$GCC" = "xyes"; then
>   changequote([,])dnl
> fi
> 
>-if ld_supports_flag --gc-sections; then
>-  SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
>-  CFLAGS="-ffunction-sections -fdata-sections $CFLAGS"
>+# Disabling gc-sections makes our binaries bigger, but some toolchains
>+# have known-broken support for it which discards sections that are needed.
>+# See https://bugs.freedesktop.org/show_bug.cgi?id=33466
>+SECTION_LDFLAGS=
>+AC_ARG_ENABLE([gc-sections],
>+  [AS_HELP_STRING([--disable-gc-sections],
>+    [disable --gc-sections to work around broken toolchains])],
>+  [enable_gc_sections=$enableval],
>+  [enable_gc_sections=yes])
>+if test "x$GCC,$enable_gc_sections,$dbus_win" = xyes,yes,no; then
>+  save_CFLAGS="$CFLAGS"
>+  save_LDFLAGS="$LDFLAGS"
>+  AC_MSG_CHECKING([for ability to link with --gc-sections])
>+  CFLAGS="-ffunction-sections -fdata-sections"
>+  LDFLAGS="-Wl,--gc-sections"
>+  AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])],
>+    [rc=yes],
>+    [rc=no])
>+  AC_MSG_RESULT([$rc])
>+  CFLAGS="$save_CFLAGS"
>+  LDFLAGS="$save_LDFLAGS"
>+  if test "x$rc" = xyes; then
>+    SECTION_LDFLAGS="-Wl,--gc-sections"
>+    CFLAGS="-ffunction-sections -fdata-sections $CFLAGS"
>+  fi
> fi
>-AC_SUBST(SECTION_FLAGS)
>-AC_SUBST(SECTION_LDFLAGS)
>-AC_MSG_RESULT($ac_gcsections)
>+AC_SUBST([SECTION_LDFLAGS])
> 
> case $host_os in
>     solaris*)
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 33466: 42822 | 43614 | 47591 | 47592

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.