Attachment 44156 Details for Bug 35016 – drm/i915: fix Gen4+ has non-power-of-two strides

[patch] drm/i915: fix Gen4+ has non-power-of-two strides

0001-drm-i915-fix-Gen4-has-non-power-of-two-strides.patch (text/plain), 1.07 KB, created by Kamal Mostafa on 2011-03-05 13:43:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kamal Mostafa

Created: 2011-03-05 13:43:15 UTC

Size: 1.07 KB

patch

obsolete

>From 4539bfa4a188e69d3534f8e881167d51829f0261 Mon Sep 17 00:00:00 2001
>From: Kamal Mostafa <kamal@canonical.com>
>Date: Sat, 5 Mar 2011 13:04:58 -0800
>Subject: [PATCH] drm/i915: fix Gen4+ has non-power-of-two strides
>
>Add missing "return true;" accidentally omitted by commit
>"drm/i915: Gen4+ has non-power-of-two strides", breaking Gen4 tiling
>for some stride/size values.
>
>BugLink: https://bugs.freedesktop.org/35016
>Signed-off-by: Kamal Mostafa <kamal@canonical.com>
>---
> drivers/gpu/drm/i915/i915_gem_tiling.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c b/drivers/gpu/drm/i915/i915_gem_tiling.c
>index 654f350..424fd70 100644
>--- a/drivers/gpu/drm/i915/i915_gem_tiling.c
>+++ b/drivers/gpu/drm/i915/i915_gem_tiling.c
>@@ -219,6 +219,7 @@ i915_tiling_ok(struct drm_device *dev, int stride, int size, int tiling_mode)
> 		/* 965+ just needs multiples of tile width */
> 		if (stride & (tile_width - 1))
> 			return false;
>+		return true;
> 	} else {
> 		/* Pre-965 needs power of two tile widths */
> 		if (stride < tile_width)
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 35016: 44123 | 44125 | 44126 | 44127 | 44154 | 44155 | 44156

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.