Attachment 44297 Details for Bug 34527 – [PATCH] protocol: introduce four new errors

[patch] [PATCH] protocol: introduce four new errors

-protocol-introduce-four-new-errors.patch (text/plain), 2.08 KB, created by Lennart Poettering on 2011-03-09 19:19:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lennart Poettering

Created: 2011-03-09 19:19:48 UTC

Size: 2.08 KB

patch

obsolete

>From d0923ef7810f9d16022eb5e5a4beac2424780b7b Mon Sep 17 00:00:00 2001
>From: Lennart Poettering <lennart@poettering.net>
>Date: Thu, 10 Mar 2011 04:06:32 +0100
>Subject: [PATCH] protocol: introduce four new errors
>
>UnknownInterface, UnknownObject, UnknownProperty and PropertyReadOnly,
>as discussed on the ML.
>
>The first two are already used by various bindings, such as the Qt and
>Java binding, but have never been made official.
>---
> dbus/dbus-protocol.h |   10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
>diff --git a/dbus/dbus-protocol.h b/dbus/dbus-protocol.h
>index 17798e9..8aa15e5 100644
>--- a/dbus/dbus-protocol.h
>+++ b/dbus/dbus-protocol.h
>@@ -189,7 +189,7 @@ extern "C" {
>  * arg0='hello' is OK, arg3489720987='hello' is not
>  */
> #define DBUS_MAXIMUM_MATCH_RULE_ARG_NUMBER 63
>-  
>+
> /** Max length of a marshaled array in bytes (64M, 2^26) We use signed
>  * int for lengths so must be INT_MAX or less.  We need something a
>  * bit smaller than INT_MAX because the array is inside a message with
>@@ -390,6 +390,14 @@ extern "C" {
> #define DBUS_ERROR_FILE_EXISTS                "org.freedesktop.DBus.Error.FileExists"
> /** Method name you invoked isn't known by the object you invoked it on. */
> #define DBUS_ERROR_UNKNOWN_METHOD             "org.freedesktop.DBus.Error.UnknownMethod"
>+/** Object you invoked a method on isn't known. */
>+#define DBUS_ERROR_UNKNOWN_OBJECT             "org.freedesktop.DBus.Error.UnknownObject"
>+/** Interface you invoked a method on isn't known by the object. */
>+#define DBUS_ERROR_UNKNOWN_INTERFACE          "org.freedesktop.DBus.Error.UnknownInterface"
>+/** Property you tried to access isn't known by the object. */
>+#define DBUS_ERROR_UNKNOWN_PROPERTY           "org.freedesktop.DBus.Error.UnknownProperty"
>+/** Property you tried to set is read-only. */
>+#define DBUS_ERROR_PROPERTY_READ_ONLY         "org.freedesktop.DBus.Error.PropertyReadOnly"
> /** Certain timeout errors, e.g. while starting a service.
>  * @warning this is confusingly-named given that #DBUS_ERROR_TIMEOUT also exists. We can't fix
>  * it for compatibility reasons so just be careful.
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 34527: 44295 | 44296 | 44297 | 44332

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.