Attachment 44731 Details for Bug 35502 – fix record parsing

[patch] fix record parsing

0001-drm-radeon-kms-add-some-sanity-checks-to-obj-info-re.patch (text/plain), 1.59 KB, created by Alex Deucher on 2011-03-22 15:19:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-03-22 15:19:49 UTC

Size: 1.59 KB

patch

obsolete

>From 80090ba2d9eab1de4eb09ca5d40697b0f039a9c9 Mon Sep 17 00:00:00 2001
>From: John Lindgren <john.lindgren@tds.net>
>Date: Tue, 22 Mar 2011 18:15:10 -0400
>Subject: [PATCH] drm/radeon/kms: add some sanity checks to obj info record parsing
>
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=35502
>
>agd5f: also add sanity check to connector records.
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/radeon/radeon_atombios.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
>index 4a92b6d..793bbd7 100644
>--- a/drivers/gpu/drm/radeon/radeon_atombios.c
>+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
>@@ -678,7 +678,8 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev)
> 							ATOM_ENCODER_CAP_RECORD *cap_record;
> 							u16 caps = 0;
> 
>-							while (record->ucRecordType > 0 &&
>+							while (record->ucRecordSize > 0 &&
>+							       record->ucRecordType > 0 &&
> 							       record->ucRecordType <= ATOM_MAX_OBJECT_RECORD_NUMBER) {
> 								switch (record->ucRecordType) {
> 								case ATOM_ENCODER_CAP_RECORD_TYPE:
>@@ -723,7 +724,8 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev)
> 									break;
> 							}
> 
>-							while (record->ucRecordType > 0 &&
>+							while (record->ucRecordSize > 0 &&
>+							       record->ucRecordType > 0 &&
> 							       record->ucRecordType <= ATOM_MAX_OBJECT_RECORD_NUMBER) {
> 								switch (record->ucRecordType) {
> 								case ATOM_I2C_RECORD_TYPE:
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 35502: 44669 | 44725 | 44731 | 44795

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.