Attachment 44887 Details for Bug 35024 – avoid recursion

[patch] avoid recursion

0001-More-explicitly-avoid-infinite-recursion-in-connecti.patch (text/plain), 1.06 KB, created by Colin Walters on 2011-03-26 05:53:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Walters

Created: 2011-03-26 05:53:57 UTC

Size: 1.06 KB

patch

obsolete

>From 3d37c9017c1ba78a0e26bfe20be5c36f841db749 Mon Sep 17 00:00:00 2001
>From: Colin Walters <walters@verbum.org>
>Date: Sat, 26 Mar 2011 08:50:53 -0400
>Subject: [PATCH] More explicitly avoid infinite recursion in connection failure
>
>There appears to be a loop:
>
>While I think the intention was that CA_CONTEXT_NOFAIL wasn't supposed
>to invoke our callback (maybe?) we should explicitly avoid this here
>in libcanberra by clearing the "reconnect" flag; nothing was ever
>setting it to FALSE anyways.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=35024
>---
> src/pulse.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/src/pulse.c b/src/pulse.c
>index d4225d1..6a81004 100644
>--- a/src/pulse.c
>+++ b/src/pulse.c
>@@ -312,6 +312,7 @@ static void context_state_cb(pa_context *pc, void *userdata) {
>                         }
> 
>                         p->subscribed = FALSE;
>+                        p->reconnect = FALSE;
> 
>                         /* If we managed to connect once, then let's try to
>                          * reconnect, and pass NOFAIL */
>-- 
>1.7.4
>

Actions: View | Splinter Review

Attachments on bug 35024: 44136 | 44802 | 44803 | 44887

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.