Attachment 44940 Details for Bug 33046 – Don't leak the tex object miptree when replacing it

[patch] Don't leak the tex object miptree when replacing it

0001-intel-Don-t-leak-the-tex-object-miptree-when-replaci.patch (text/plain), 998 bytes, created by Ian Romanick on 2011-03-28 10:19:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Romanick

Created: 2011-03-28 10:19:59 UTC

Size: 998 bytes

patch

obsolete

>From 085a7e420affc7ce33e76e2b695dffd42944eb01 Mon Sep 17 00:00:00 2001
>From: Ian Romanick <ian.d.romanick@intel.com>
>Date: Mon, 28 Mar 2011 10:13:25 -0700
>Subject: [PATCH] intel: Don't leak the tex object miptree when replacing it
>
>---
> src/mesa/drivers/dri/intel/intel_tex_image.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mesa/drivers/dri/intel/intel_tex_image.c
>index 906f8a6..b3a2b1b 100644
>--- a/src/mesa/drivers/dri/intel/intel_tex_image.c
>+++ b/src/mesa/drivers/dri/intel/intel_tex_image.c
>@@ -370,8 +370,10 @@ intelTexImage(struct gl_context * ctx,
>        * whole object since our level didn't fit what was there
>        * before, and any lower levels would fit into our miptree.
>        */
>-      if (intelImage->mt)
>+      if (intelImage->mt) {
>+	 intel_miptree_release(intel, &intelObj->mt);
> 	 intel_miptree_reference(&intelObj->mt, intelImage->mt);
>+      }
>    }
> 
>    /* PBO fastpaths:
>-- 
>1.7.4
>

Actions: View | Splinter Review

Attachments on bug 33046: 44940

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.