Attachment 44988 Details for Bug 35733 – Retire requests before disabling pagefaults

[patch] Retire requests before disabling pagefaults

0001-drm-i915-Retire-requests-before-disabling-pagefaults.patch (text/plain), 1.43 KB, created by Chris Wilson on 2011-03-29 02:33:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2011-03-29 02:33:42 UTC

Size: 1.43 KB

patch

obsolete

>From 0a8facaaa9026dfcfe36092401edd5a57f7e4d01 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Tue, 29 Mar 2011 10:30:06 +0100
>Subject: [PATCH] drm/i915: Retire requests before disabling pagefaults
>
>As we cannot wait upon an object to be released by the GPU once we have
>disabled pagefaults, process any pending retirements first in the hope
>that we move any potential relocations off the active list.
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=35733
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>index 0010aee..b6f89f9 100644
>--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>@@ -445,6 +445,12 @@ i915_gem_execbuffer_relocate(struct drm_device *dev,
> 	struct drm_i915_gem_object *obj;
> 	int ret = 0;
> 
>+	/* Try to move as many of the relocation targets off the active list
>+	 * to avoid unnecessary fallbacks to the slow path, as we cannot wait
>+	 * for the retirement with pagefaults disabled.
>+	 */
>+	i915_gem_retire_requests(dev);
>+
> 	/* This is the fast path and we cannot handle a pagefault whilst
> 	 * holding the struct mutex lest the user pass in the relocations
> 	 * contained within a mmaped bo. For in such a case we, the page
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 35733: 44980 | 44981 | 44983 | 44985 | 44988 | 44989

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.