Attachment 45292 Details for Bug 35766 – [PATCH 09/15] export_signals: check interface, signal names for validity

[patch] [PATCH 09/15] export_signals: check interface, signal names for validity

0009-export_signals-check-interface-signal-names-for-vali.patch (text/plain), 1.19 KB, created by Simon McVittie on 2011-04-05 10:06:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-04-05 10:06:50 UTC

Size: 1.19 KB

patch

obsolete

>From 5f723304defa49b50a3e2bdb6e9722d9fa3db987 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 5 Apr 2011 15:49:18 +0100
>Subject: [PATCH 09/15] export_signals: check interface, signal names for validity
>
>---
> dbus/dbus-gobject.c |   14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/dbus/dbus-gobject.c b/dbus/dbus-gobject.c
>index 3baa860..08ddd0e 100644
>--- a/dbus/dbus-gobject.c
>+++ b/dbus/dbus-gobject.c
>@@ -2316,6 +2316,20 @@ export_signals (DBusGConnection *connection, const GList *info_list, GObject *ob
> 
>           sigdata = signal_iterate (sigdata, &iface, &signame);
> 
>+          if (!g_dbus_is_interface_name (iface))
>+            {
>+              g_critical ("invalid interface name found in %s: %s",
>+                  g_type_name (gtype), iface);
>+              continue;
>+            }
>+
>+          if (!g_dbus_is_member_name (signame))
>+            {
>+              g_critical ("invalid signal name found in %s: %s",
>+                  g_type_name (gtype), signame);
>+              continue;
>+            }
>+
>           s = _dbus_gutils_wincaps_to_uscore (signame);
> 
>           id = g_signal_lookup (s, gtype);
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 35766: 45284 | 45285 | 45286 | 45287 | 45288 | 45289 | 45290 | 45291 | 45292 | 45293 | 45294 | 45295 | 45296 | 45297 | 45298

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.