Attachment 45404 Details for Bug 36066 – Remove unused variables

[patch] Remove unused variables

0001-fix-unused-but-set-variable-warnings.patch (text/plain), 1.72 KB, created by Marc Plano-Lesay on 2011-04-07 15:24:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Plano-Lesay

Created: 2011-04-07 15:24:18 UTC

Size: 1.72 KB

patch

obsolete

>From bb3fd42bec7dd2df23c4d4d854317fa3d04903cb Mon Sep 17 00:00:00 2001
>From: Marc Plano-Lesay <marc.planolesay@gmail.com>
>Date: Thu, 7 Apr 2011 21:54:09 +0200
>Subject: [PATCH] fix unused-but-set-variable warnings
>
>---
> src/media-stream.c |   20 --------------------
> 1 files changed, 0 insertions(+), 20 deletions(-)
>
>diff --git a/src/media-stream.c b/src/media-stream.c
>index ea300b3..50dde5b 100644
>--- a/src/media-stream.c
>+++ b/src/media-stream.c
>@@ -817,12 +817,9 @@ haze_media_stream_codec_choice (TpSvcMediaStreamHandler *iface,
>                                 DBusGMethodInvocation *context)
> {
>   HazeMediaStream *self = HAZE_MEDIA_STREAM (iface);
>-  HazeMediaStreamPrivate *priv;
> 
>   g_assert (HAZE_IS_MEDIA_STREAM (self));
> 
>-  priv = self->priv;
>-
>   tp_svc_media_stream_handler_return_from_codec_choice (context);
> }
> 
>@@ -1278,28 +1275,11 @@ haze_media_stream_stream_state (TpSvcMediaStreamHandler *iface,
>                                 DBusGMethodInvocation *context)
> {
>   HazeMediaStream *self = HAZE_MEDIA_STREAM (iface);
>-  PurpleMediaState media_state = PURPLE_MEDIA_STATE_END;
>-
>-  switch (connection_state) {
>-    case TP_MEDIA_STREAM_STATE_DISCONNECTED:
>-      media_state = PURPLE_MEDIA_STATE_END;
>-      break;
>-    case TP_MEDIA_STREAM_STATE_CONNECTING:
>-      media_state = PURPLE_MEDIA_STATE_NEW;
>-      break;
>-    case TP_MEDIA_STREAM_STATE_CONNECTED:
>-      media_state = PURPLE_MEDIA_STATE_CONNECTED;
>-      break;
>-    default:
>-      DEBUG ("ignoring unknown connection state %u", connection_state);
>-      goto OUT;
>-  }
> 
>   g_object_set (self, "connection-state", connection_state, NULL);
> 
>   // emit connection state here
> 
>-OUT:
>   tp_svc_media_stream_handler_return_from_stream_state (context);
> }
> 
>-- 
>1.7.4.4
>

Actions: View | Splinter Review

Attachments on bug 36066: 45404

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.