Attachment 45830 Details for Bug 36246 – Enable the plane after setting the base

[patch] Enable the plane after setting the base

0003-drm-i915-Only-enable-the-plane-after-setting-the-fb-.patch (text/plain), 1.18 KB, created by Chris Wilson on 2011-04-19 13:26:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2011-04-19 13:26:34 UTC

Size: 1.18 KB

patch

obsolete

>From 097e024f20298c3ec9ec7e4d86a9a76ac9a1938b Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Tue, 19 Apr 2011 21:14:14 +0100
>Subject: [PATCH 3/3] drm/i915: Only enable the plane after setting the fb base
>
>When enabling the plane, it is helpful to have already pointed that
>plane to valid memory or else we may incur the wrath of a PGTBL_ER.
>This code preserved the behaviour from the bad old days for unknown
>reasons...
>
>Found by assert_fb_bound_for_plane().
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=36246
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_display.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index b9bb20d..f503ad0 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -5212,8 +5212,6 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
> 
> 	I915_WRITE(DSPCNTR(plane), dspcntr);
> 	POSTING_READ(DSPCNTR(plane));
>-	if (!HAS_PCH_SPLIT(dev))
>-		intel_enable_plane(dev_priv, plane, pipe);
> 
> 	ret = intel_pipe_set_base(crtc, x, y, old_fb);
> 
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 36246: 45634 | 45635 | 45715 | 45724 | 45743 | 45744 | 45745 | 45829 | 45830 | 46037 | 46103

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.