Attachment 45950 Details for Bug 28918 – 0003 Strengthen the MUC JOIN test to forbid duplicate NewChannels

[patch] 0003 Strengthen the MUC JOIN test to forbid duplicate NewChannels

0003-Strengthen-the-MUC-JOIN-test-to-forbid-duplicate-New.patch (text/plain), 1.47 KB, created by Debarshi Ray on 2011-04-22 05:19:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Debarshi Ray

Created: 2011-04-22 05:19:44 UTC

Size: 1.47 KB

patch

obsolete

>From 8308365318aeb8a952ca87e1c3c8c9ddee2dcc43 Mon Sep 17 00:00:00 2001
>From: Debarshi Ray <rishi@gnu.org>
>Date: Fri, 22 Apr 2011 15:14:37 +0300
>Subject: [PATCH] Strengthen the MUC JOIN test to forbid duplicate NewChannels
>
>---
> tests/twisted/channels/join-muc-channel.py |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/tests/twisted/channels/join-muc-channel.py b/tests/twisted/channels/join-muc-channel.py
>index 0ad6417..613756e 100644
>--- a/tests/twisted/channels/join-muc-channel.py
>+++ b/tests/twisted/channels/join-muc-channel.py
>@@ -22,7 +22,9 @@ def test(q, bus, conn, stream):
>     event = q.expect('dbus-return', method='RequestChannel')
>     obj_path = event.value[0]
> 
>-    event = q.expect('dbus-signal', signal='NewChannels')
>+    pattern = EventPattern('dbus-signal', signal='NewChannels')
>+    event = q.expect_many(pattern)[0]
>+    q.forbid_events([pattern])
>     channel_details = event.args[0]
>     assert len(channel_details) == 1
>     path, props = channel_details[0]
>@@ -31,7 +33,9 @@ def test(q, bus, conn, stream):
>     assert props[TARGET_HANDLE] == room_handles[0]
>     assert props[CHANNEL_TYPE] == CHANNEL_TYPE_TEXT
> 
>-    event = q.expect('dbus-signal', signal='NewChannel')
>+    pattern = EventPattern('dbus-signal', signal='NewChannel')
>+    event = q.expect_many(pattern)[0]
>+    q.forbid_events([pattern])
>     assert event.args[0] == obj_path
>     assert event.args[1] == CHANNEL_TYPE_TEXT
>     assert event.args[2] == HT_ROOM
>-- 
>1.7.4.2
>

Actions: View | Splinter Review

Attachments on bug 28918: 45793 | 45949 | 45950 | 46264 | 46265

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.