Attachment 46291 Details for Bug 36793 – [6/6] Add a regression test for re-registering an object at the same path

[patch] [6/6] Add a regression test for re-registering an object at the same path

0006-Add-a-regression-test-for-re-registering-an-object-a.patch (text/plain), 1.96 KB, created by Simon McVittie on 2011-05-03 08:10:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-05-03 08:10:44 UTC

Size: 1.96 KB

patch

obsolete

>From 4c02ee2b12cca8fc4a7bfb3dfb87160a81a889ea Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 3 May 2011 16:06:25 +0100
>Subject: [PATCH 6/6] Add a regression test for re-registering an object at
> the same path
>
>---
> test/core/registrations.c |   24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
>
>diff --git a/test/core/registrations.c b/test/core/registrations.c
>index befef06..bcdaa14 100644
>--- a/test/core/registrations.c
>+++ b/test/core/registrations.c
>@@ -140,6 +140,28 @@ test_unregister_on_forced_dispose (Fixture *f,
>   g_assert (dbus_g_connection_lookup_g_object (f->bus, "/foo") == NULL);
> }
> 
>+static void
>+test_reregister (Fixture *f,
>+    gconstpointer test_data G_GNUC_UNUSED)
>+{
>+  dbus_g_connection_register_g_object (f->bus, "/foo", f->object);
>+  g_assert (dbus_g_connection_lookup_g_object (f->bus, "/foo") ==
>+      f->object);
>+
>+  /* Before 0.82, re-registering the same object path was leaky but successful.
>+   * 0.82 disallowed this behaviour. Since 0.84 it was meant to be allowed
>+   * again, and a no-op, but it actually had the effect of removing all
>+   * record of the registrations (while leaving the object registered with
>+   * libdbus). */
>+  dbus_g_connection_register_g_object (f->bus, "/foo", f->object);
>+  g_assert (dbus_g_connection_lookup_g_object (f->bus, "/foo") ==
>+      f->object);
>+
>+  /* This would critical in 0.84. */
>+  dbus_g_connection_unregister_g_object (f->bus, f->object);
>+  g_assert (dbus_g_connection_lookup_g_object (f->bus, "/foo") == NULL);
>+}
>+
> int
> main (int argc, char **argv)
> {
>@@ -159,6 +181,8 @@ main (int argc, char **argv)
>       setup, test_unregister_on_last_unref, teardown);
>   g_test_add ("/registrations/unregister-on-forced-dispose", Fixture, NULL,
>       setup, test_unregister_on_forced_dispose, teardown);
>+  g_test_add ("/registrations/reregister", Fixture, NULL,
>+      setup, test_reregister, teardown);
> 
>   return g_test_run ();
> }
>-- 
>1.7.4.4
>

Actions: View | Splinter Review

Attachments on bug 36793: 46286 | 46287 | 46288 | 46289 | 46290 | 46291 | 46314 | 46315

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.