Attachment 46534 Details for Bug 37062 – [PATCH 3/6] marshal_map, marshal_struct: remove unused variable ret

[patch] [PATCH 3/6] marshal_map, marshal_struct: remove unused variable ret

0003-marshal_map-marshal_struct-remove-unused-variable-re.patch (text/plain), 1.30 KB, created by Simon McVittie on 2011-05-10 03:35:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-05-10 03:35:47 UTC

Size: 1.30 KB

patch

obsolete

>From 5cfbcecba5ef3fdf887390aad26dc4688178bddf Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 4 May 2011 15:18:48 +0100
>Subject: [PATCH 3/6] marshal_map, marshal_struct: remove unused variable ret
>
>gcc 4.6 warns about these.
>---
> dbus/dbus-gvalue.c |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/dbus/dbus-gvalue.c b/dbus/dbus-gvalue.c
>index 323d731..dcbd2d2 100644
>--- a/dbus/dbus-gvalue.c
>+++ b/dbus/dbus-gvalue.c
>@@ -1669,7 +1669,6 @@ marshal_map (DBusMessageIter   *iter,
> {
>   GType gtype;
>   DBusMessageIter arr_iter;
>-  gboolean ret;
>   struct DBusGLibHashMarshalData hashdata;
>   char *key_sig;
>   char *value_sig;
>@@ -1680,8 +1679,6 @@ marshal_map (DBusMessageIter   *iter,
> 
>   gtype = G_VALUE_TYPE (value);
> 
>-  ret = FALSE;
>-
>   key_type = dbus_g_type_get_map_key_specialization (gtype);
>   g_assert (_dbus_gtype_is_valid_hash_key (key_type));
>   value_type = dbus_g_type_get_map_value_specialization (gtype);
>@@ -1746,14 +1743,11 @@ marshal_struct (DBusMessageIter   *iter,
> {
>   GType gtype;
>   DBusMessageIter subiter;
>-  gboolean ret;
>   guint size, i;
>   GValue val = {0,};
> 
>   gtype = G_VALUE_TYPE (value);
> 
>-  ret = FALSE;
>-
>   size = dbus_g_type_get_struct_size (gtype);
> 
>   if (!dbus_message_iter_open_container (iter,
>-- 
>1.7.5.1
>

Actions: View | Splinter Review

Attachments on bug 37062: 46532 | 46533 | 46534 | 46535 | 46536 | 46537

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.