Attachment 47066 Details for Bug 37515 – Remove unused but set variables

[patch] Remove unused but set variables

0001-Remove-unused-but-set-variables.patch (text/plain), 1.69 KB, created by Debarshi Ray on 2011-05-23 12:37:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Debarshi Ray

Created: 2011-05-23 12:37:44 UTC

Size: 1.69 KB

patch

obsolete

>From fc9c7c652ec64c46113b3e4d3d95b595dc00757b Mon Sep 17 00:00:00 2001
>From: Debarshi Ray <rishi@gnu.org>
>Date: Tue, 24 May 2011 01:06:32 +0530
>Subject: [PATCH] Remove unused but set variables
>
>This is needed to satisfy the new -Wunused-but-set-variable added in
>GCC 4.6: http://gcc.gnu.org/gcc-4.6/changes.html
>
>Fixes: https://bugs.freedesktop.org/37515
>---
> src/idle-muc-channel.c |    8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
>diff --git a/src/idle-muc-channel.c b/src/idle-muc-channel.c
>index 8afc0ce..756d192 100644
>--- a/src/idle-muc-channel.c
>+++ b/src/idle-muc-channel.c
>@@ -1428,13 +1428,10 @@ void idle_muc_channel_topic(IdleMUCChannel *chan, const char *topic) {
> 	GValue prop = {0, };
> 	GValue val = {0, };
> 	GPtrArray *arr;
>-	IdleMUCChannelPrivate *priv;
> 
> 	g_assert(chan != NULL);
> 	g_assert(topic != NULL);
> 
>-	priv = IDLE_MUC_CHANNEL_GET_PRIVATE(chan);
>-
> 	g_value_init(&prop, TP_TYPE_PROPERTY_VALUE_STRUCT);
> 	g_value_take_boxed(&prop, dbus_g_type_specialized_construct(TP_TYPE_PROPERTY_VALUE_STRUCT));
> 
>@@ -1992,8 +1989,6 @@ static void idle_muc_channel_list_properties (TpSvcPropertiesInterface *iface, D
> 	for (int i = 0; i < LAST_TP_PROPERTY_ENUM; i++) {
> 		GValue prop = {0, };
> 		const gchar *dbus_sig;
>-		const gchar *name;
>-		guint flags;
> 
> 		switch (property_signatures[i].type) {
> 			case G_TYPE_BOOLEAN:
>@@ -2022,9 +2017,6 @@ static void idle_muc_channel_list_properties (TpSvcPropertiesInterface *iface, D
> 		g_value_take_boxed(&prop,
> 				dbus_g_type_specialized_construct(TP_TYPE_PROPERTY_INFO_STRUCT));
> 
>-		name = property_signatures[i].name;
>-		flags = priv->properties[i].flags;
>-
> 		dbus_g_type_struct_set(&prop,
> 				0, i,
> 				1, property_signatures[i].name,
>-- 
>1.7.5.1
>

Actions: View | Splinter Review

Attachments on bug 37515: 47066

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.