Attachment 47189 Details for Bug 37522 – viewport height has to be even

[patch] viewport height has to be even

0001-drm-radeon-kms-viewport-height-has-to-be-even.patch (text/plain), 2.25 KB, created by Alex Deucher on 2011-05-26 07:33:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-05-26 07:33:27 UTC

Size: 2.25 KB

patch

obsolete

>From 78730fbbacb91dc01ac42da4b3f015d2b7498e01 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Thu, 26 May 2011 10:24:14 -0400
>Subject: [PATCH] drm/radeon/kms: viewport height has to be even
>
>Otherwise, no vblank interrupts.
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=37522
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/radeon/atombios_crtc.c |   12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
>index ec84878..84a69e7 100644
>--- a/drivers/gpu/drm/radeon/atombios_crtc.c
>+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
>@@ -1045,7 +1045,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> 	uint64_t fb_location;
> 	uint32_t fb_format, fb_pitch_pixels, tiling_flags;
> 	u32 fb_swap = EVERGREEN_GRPH_ENDIAN_SWAP(EVERGREEN_GRPH_ENDIAN_NONE);
>-	u32 tmp;
>+	u32 tmp, viewport_w, viewport_h;
> 	int r;
> 
> 	/* no fb bound */
>@@ -1171,8 +1171,10 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> 	y &= ~1;
> 	WREG32(EVERGREEN_VIEWPORT_START + radeon_crtc->crtc_offset,
> 	       (x << 16) | y);
>+	viewport_w = crtc->mode.hdisplay;
>+	viewport_h = (crtc->mode.vdisplay + 1) & ~1;
> 	WREG32(EVERGREEN_VIEWPORT_SIZE + radeon_crtc->crtc_offset,
>-	       (crtc->mode.hdisplay << 16) | crtc->mode.vdisplay);
>+	       (viewport_w << 16) | viewport_h);
> 
> 	/* pageflip setup */
> 	/* make sure flip is at vb rather than hb */
>@@ -1213,7 +1215,7 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> 	uint64_t fb_location;
> 	uint32_t fb_format, fb_pitch_pixels, tiling_flags;
> 	u32 fb_swap = R600_D1GRPH_SWAP_ENDIAN_NONE;
>-	u32 tmp;
>+	u32 tmp, viewport_w, viewport_h;
> 	int r;
> 
> 	/* no fb bound */
>@@ -1338,8 +1340,10 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> 	y &= ~1;
> 	WREG32(AVIVO_D1MODE_VIEWPORT_START + radeon_crtc->crtc_offset,
> 	       (x << 16) | y);
>+	viewport_w = crtc->mode.hdisplay;
>+	viewport_h = (crtc->mode.vdisplay + 1) & ~1;
> 	WREG32(AVIVO_D1MODE_VIEWPORT_SIZE + radeon_crtc->crtc_offset,
>-	       (crtc->mode.hdisplay << 16) | crtc->mode.vdisplay);
>+	       (viewport_w << 16) | viewport_h);
> 
> 	/* pageflip setup */
> 	/* make sure flip is at vb rather than hb */
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 37522: 47078 | 47079 | 47080 | 47189

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.