Attachment 48228 Details for Bug 38524 – channel-iface: set TP_UNKNOWN_HANDLE_TYPE as default handle type

[patch] channel-iface: set TP_UNKNOWN_HANDLE_TYPE as default handle type

channel-iface-set-TPUNKNOWNHANDLETYPE-as-default-h.patch (text/plain), 1.35 KB, created by Guillaume Desmottes on 2011-06-21 06:43:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2011-06-21 06:43:56 UTC

Size: 1.35 KB

patch

obsolete

>From 00487141eab9a0cc35c8dd32a8b5b30e0bae36a3 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Tue, 21 Jun 2011 15:39:43 +0200
>Subject: [PATCH] channel-iface: set TP_UNKNOWN_HANDLE_TYPE as default handle type
>
>TP_HANDLE_TYPE_NONE is not a good default, if we don't know the handle type we
>shouln't try to guess it.
>This also confuses TpChannel which think we are setting a valid handle type;
>see fdo#38524.
>---
> telepathy-glib/channel-iface.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/telepathy-glib/channel-iface.c b/telepathy-glib/channel-iface.c
>index 7903586..8331a04 100644
>--- a/telepathy-glib/channel-iface.c
>+++ b/telepathy-glib/channel-iface.c
>@@ -30,6 +30,7 @@
>  */
> 
> #include <telepathy-glib/channel-iface.h>
>+#include <telepathy-glib/handle.h>
> 
> static void
> tp_channel_iface_base_init (gpointer klass)
>@@ -95,7 +96,7 @@ tp_channel_iface_base_init (gpointer klass)
>      */
>     param_spec = g_param_spec_uint ("handle-type", "Handle type",
>         "The TpHandleType of this channel's associated handle.",
>-        0, G_MAXUINT32, 0,
>+        0, G_MAXUINT32, TP_UNKNOWN_HANDLE_TYPE,
>         G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE |
>         G_PARAM_STATIC_NAME | G_PARAM_STATIC_BLURB | G_PARAM_STATIC_NICK);
>     g_object_interface_install_property (klass, param_spec);
>-- 
>1.7.4.1

Actions: View | Splinter Review

Attachments on bug 38524: 48228

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.