Attachment 48778 Details for Bug 34881 – Don't put const before G*List, it does not make sense

[patch] Don't put const before G*List, it does not make sense

Dont-put-const-before-GList-it-does-not-make-sense.patch (text/plain), 6.01 KB, created by Will Thompson on 2011-07-05 10:57:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Will Thompson

Created: 2011-07-05 10:57:27 UTC

Size: 6.01 KB

patch

obsolete

>From 5e525b1a878b1271a54b634b3505eb735e228d1d Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= <olivier.crete@collabora.co.uk>
>Date: Tue, 5 Jul 2011 18:55:26 +0100
>Subject: [PATCH] Don't put const before G*List, it does not make sense
>
>---
> wocky/wocky-auth-registry.c         |   12 ++++++------
> wocky/wocky-auth-registry.h         |    4 ++--
> wocky/wocky-pubsub-node-protected.h |    2 +-
> wocky/wocky-pubsub-node.c           |    6 +++---
> wocky/wocky-pubsub-node.h           |    2 +-
> wocky/wocky-utils.c                 |    4 ++--
> wocky/wocky-utils.h                 |    2 +-
> 7 files changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/wocky/wocky-auth-registry.c b/wocky/wocky-auth-registry.c
>index 24e9d5c..d52cadb 100644
>--- a/wocky/wocky-auth-registry.c
>+++ b/wocky/wocky-auth-registry.c
>@@ -24,7 +24,7 @@ struct _WockyAuthRegistryPrivate
> };
> 
> static void wocky_auth_registry_start_auth_async_func (WockyAuthRegistry *self,
>-    const GSList *mechanisms,
>+    GSList *mechanisms,
>     gboolean allow_plain,
>     gboolean is_secure_channel,
>     const gchar *username,
>@@ -172,10 +172,10 @@ wocky_auth_registry_new (void)
> }
> 
> static gboolean
>-wocky_auth_registry_has_mechanism (const GSList *list, const gchar *mech) {
>+wocky_auth_registry_has_mechanism (GSList *list, const gchar *mech) {
>   GSList *t;
> 
>-  t = g_slist_find_custom ((GSList *) list, mech, (GCompareFunc) g_strcmp0);
>+  t = g_slist_find_custom (list, mech, (GCompareFunc) g_strcmp0);
> 
>   return (t != NULL);
> }
>@@ -214,7 +214,7 @@ wocky_auth_registry_start_data_free (WockyAuthRegistryStartData *start_data)
> 
> static WockyAuthHandler *
> wocky_auth_registry_select_handler (WockyAuthRegistry *self,
>-    gboolean allow_plain, const GSList *mechanisms)
>+    gboolean allow_plain, GSList *mechanisms)
> {
>   WockyAuthRegistryPrivate *priv = self->priv;
>   GSList *k;
>@@ -239,7 +239,7 @@ wocky_auth_registry_select_handler (WockyAuthRegistry *self,
> 
> static void
> wocky_auth_registry_start_auth_async_func (WockyAuthRegistry *self,
>-    const GSList *mechanisms,
>+    GSList *mechanisms,
>     gboolean allow_plain,
>     gboolean is_secure_channel,
>     const gchar *username,
>@@ -336,7 +336,7 @@ wocky_auth_registry_start_auth_async_func (WockyAuthRegistry *self,
> 
> void
> wocky_auth_registry_start_auth_async (WockyAuthRegistry *self,
>-    const GSList *mechanisms,
>+    GSList *mechanisms,
>     gboolean allow_plain,
>     gboolean is_secure_channel,
>     const gchar *username,
>diff --git a/wocky/wocky-auth-registry.h b/wocky/wocky-auth-registry.h
>index e93a92c..eaae015 100644
>--- a/wocky/wocky-auth-registry.h
>+++ b/wocky/wocky-auth-registry.h
>@@ -137,7 +137,7 @@ typedef struct _WockyAuthRegistryPrivate WockyAuthRegistryPrivate;
>  * supports and gets the initial data from the chosen handler.
>  */
> typedef void (*WockyAuthRegistryStartAuthAsyncFunc) (WockyAuthRegistry *self,
>-    const GSList *mechanisms,
>+    GSList *mechanisms,
>     gboolean allow_plain,
>     gboolean is_secure_channel,
>     const gchar *username,
>@@ -276,7 +276,7 @@ GType wocky_auth_registry_get_type (void) G_GNUC_CONST;
> WockyAuthRegistry *wocky_auth_registry_new (void);
> 
> void wocky_auth_registry_start_auth_async (WockyAuthRegistry *self,
>-    const GSList *mechanisms,
>+    GSList *mechanisms,
>     gboolean allow_plain,
>     gboolean is_secure_channel,
>     const gchar *username,
>diff --git a/wocky/wocky-pubsub-node-protected.h b/wocky/wocky-pubsub-node-protected.h
>index 8e7f65e..d4c8a20 100644
>--- a/wocky/wocky-pubsub-node-protected.h
>+++ b/wocky/wocky-pubsub-node-protected.h
>@@ -76,7 +76,7 @@ GList *wocky_pubsub_node_parse_affiliations (
> 
> WockyStanza *wocky_pubsub_node_make_modify_affiliates_stanza (
>     WockyPubsubNode *self,
>-    const GList *affiliates,
>+    GList *affiliates,
>     WockyNode **pubsub_node,
>     WockyNode **affiliations_node);
> 
>diff --git a/wocky/wocky-pubsub-node.c b/wocky/wocky-pubsub-node.c
>index 5228e14..31fd0fe 100644
>--- a/wocky/wocky-pubsub-node.c
>+++ b/wocky/wocky-pubsub-node.c
>@@ -898,13 +898,13 @@ wocky_pubsub_node_list_affiliates_finish (
> WockyStanza *
> wocky_pubsub_node_make_modify_affiliates_stanza (
>     WockyPubsubNode *self,
>-    const GList *affiliates,
>+    GList *affiliates,
>     WockyNode **pubsub_node,
>     WockyNode **affiliations_node)
> {
>   WockyStanza *stanza;
>   WockyNode *affiliations;
>-  const GList *l;
>+  GList *l;
> 
>   stanza = pubsub_node_make_action_stanza (self, WOCKY_STANZA_SUB_TYPE_SET,
>       WOCKY_XMPP_NS_PUBSUB_OWNER, "affiliations", NULL,
>@@ -967,7 +967,7 @@ wocky_pubsub_node_make_modify_affiliates_stanza (
> void
> wocky_pubsub_node_modify_affiliates_async (
>     WockyPubsubNode *self,
>-    const GList *affiliates,
>+    GList *affiliates,
>     GCancellable *cancellable,
>     GAsyncReadyCallback callback,
>     gpointer user_data)
>diff --git a/wocky/wocky-pubsub-node.h b/wocky/wocky-pubsub-node.h
>index 1444780..b127dd1 100644
>--- a/wocky/wocky-pubsub-node.h
>+++ b/wocky/wocky-pubsub-node.h
>@@ -166,7 +166,7 @@ gboolean wocky_pubsub_node_list_affiliates_finish (
> 
> void wocky_pubsub_node_modify_affiliates_async (
>     WockyPubsubNode *self,
>-    const GList *affiliates,
>+    GList *affiliates,
>     GCancellable *cancellable,
>     GAsyncReadyCallback callback,
>     gpointer user_data);
>diff --git a/wocky/wocky-utils.c b/wocky/wocky-utils.c
>index 88f75af..cc80048 100644
>--- a/wocky/wocky-utils.c
>+++ b/wocky/wocky-utils.c
>@@ -696,10 +696,10 @@ wocky_absolutize_path (const gchar *path)
> 
> GList *
> wocky_list_deep_copy (GBoxedCopyFunc copy,
>-    const GList *items)
>+    GList *items)
> {
>   GList *ret = NULL;
>-  const GList *l;
>+  GList *l;
> 
>   g_return_val_if_fail (copy != NULL, NULL);
> 
>diff --git a/wocky/wocky-utils.h b/wocky/wocky-utils.h
>index cc143be..48edf74 100644
>--- a/wocky/wocky-utils.h
>+++ b/wocky/wocky-utils.h
>@@ -64,7 +64,7 @@ const gchar *wocky_enum_to_nick (GType enum_type, gint value);
> 
> gchar *wocky_absolutize_path (const gchar *path);
> 
>-GList *wocky_list_deep_copy (GBoxedCopyFunc copy, const GList *items);
>+GList *wocky_list_deep_copy (GBoxedCopyFunc copy, GList *items);
> 
> GString *wocky_g_string_dup (const GString *str);
> 
>-- 
>1.7.5.4

Actions: View | Splinter Review

Attachments on bug 34881: 43985 | 43986 | 48778 | 48779 | 48780

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.