Attachment 48827 Details for Bug 30266 – 0001-intel-Fix-use-of-freed-buffer-if-glBitmap-is-called-.patch

[patch] 0001-intel-Fix-use-of-freed-buffer-if-glBitmap-is-called-.patch

0001-intel-Fix-use-of-freed-buffer-if-glBitmap-is-called-.patch (text/plain), 1.57 KB, created by Eric Anholt on 2011-07-06 11:45:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Anholt

Created: 2011-07-06 11:45:18 UTC

Size: 1.57 KB

patch

obsolete

>From f98c919952b1b23c8e63893e5596cd097980f8ba Mon Sep 17 00:00:00 2001
>From: Eric Anholt <eric@anholt.net>
>Date: Wed, 6 Jul 2011 11:31:00 -0700
>Subject: [PATCH] intel: Fix use of freed buffer if glBitmap is called after a
> swap.
>
>Regions looked up from the framebuffer are invalid after
>intel_prepare_render().
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30266
>---
> src/mesa/drivers/dri/intel/intel_pixel_bitmap.c |    7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c b/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>index 64c7acc..86d0ef2 100644
>--- a/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>+++ b/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>@@ -175,7 +175,7 @@ do_blit_bitmap( struct gl_context *ctx,
> 		const GLubyte *bitmap )
> {
>    struct intel_context *intel = intel_context(ctx);
>-   struct intel_region *dst = intel_drawbuf_region(intel);
>+   struct intel_region *dst;
>    struct gl_framebuffer *fb = ctx->DrawBuffer;
>    GLfloat tmpColor[4];
>    GLubyte ubcolor[4];
>@@ -198,6 +198,9 @@ do_blit_bitmap( struct gl_context *ctx,
>       return GL_FALSE;
>    }
> 
>+   intel_prepare_render(intel);
>+   dst = intel_drawbuf_region(intel);
>+
>    if (!dst)
>        return GL_FALSE;
> 
>@@ -226,8 +229,6 @@ do_blit_bitmap( struct gl_context *ctx,
>    if (!intel_check_blit_fragment_ops(ctx, tmpColor[3] == 1.0F))
>       return GL_FALSE;
> 
>-   intel_prepare_render(intel);
>-
>    /* Clip to buffer bounds and scissor. */
>    if (!_mesa_clip_to_region(fb->_Xmin, fb->_Ymin,
> 			     fb->_Xmax, fb->_Ymax,
>-- 
>1.7.5.4
>

Actions: View | Splinter Review

Attachments on bug 30266: 47168 | 48827

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.