Attachment 49352 Details for Bug 21168 – Connection: replace constructor with constructed.

[patch] Connection: replace constructor with constructed.

Connection-replace-constructor-with-constructed.patch (text/plain), 1.73 KB, created by Will Thompson on 2011-07-20 11:27:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Will Thompson

Created: 2011-07-20 11:27:22 UTC

Size: 1.73 KB

patch

obsolete

>From ea8181bf64c55fb50946880513008e0b489efe76 Mon Sep 17 00:00:00 2001
>From: Will Thompson <will.thompson@collabora.co.uk>
>Date: Wed, 20 Jul 2011 18:36:33 +0100
>Subject: [PATCH] Connection: replace constructor with constructed.
>
>---
> src/idle-connection.c |   15 +++++++--------
> 1 files changed, 7 insertions(+), 8 deletions(-)
>
>diff --git a/src/idle-connection.c b/src/idle-connection.c
>index 5b83700..d6f5796 100644
>--- a/src/idle-connection.c
>+++ b/src/idle-connection.c
>@@ -225,14 +225,13 @@ static void idle_connection_init(IdleConnection *obj) {
> 	priv->msg_queue = g_queue_new();
> }
> 
>-static GObject *idle_connection_constructor(GType type, guint n_params, GObjectConstructParam *params) {
>-	IdleConnection *self = IDLE_CONNECTION(G_OBJECT_CLASS(idle_connection_parent_class)->constructor(type, n_params, params));
>-
>-	self->parser = g_object_new(IDLE_TYPE_PARSER, "connection", self, NULL);
>-
>-	idle_contact_info_init(self);
>+static void
>+idle_connection_constructed (GObject *object)
>+{
>+  IdleConnection *self = IDLE_CONNECTION (object);
> 
>-	return (GObject *) self;
>+  self->parser = g_object_new (IDLE_TYPE_PARSER, "connection", self, NULL);
>+  idle_contact_info_init (self);
> }
> 
> static void idle_connection_set_property(GObject *obj, guint prop_id, const GValue *value, GParamSpec *pspec) {
>@@ -426,7 +425,7 @@ static void idle_connection_class_init(IdleConnectionClass *klass) {
> 
> 	g_type_class_add_private(klass, sizeof(IdleConnectionPrivate));
> 
>-	object_class->constructor = idle_connection_constructor;
>+	object_class->constructed = idle_connection_constructed;
> 	object_class->set_property = idle_connection_set_property;
> 	object_class->get_property = idle_connection_get_property;
> 	object_class->dispose = idle_connection_dispose;
>-- 
>1.7.5.4

Actions: View | Splinter Review

Attachments on bug 21168: 49350 | 49351 | 49352 | 49353 | 49354 | 49355

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.