Attachment 49702 Details for Bug 38313 – 0001-dix-don-t-XWarpPointer-through-the-last-slave-anymor.patch

[patch] 0001-dix-don-t-XWarpPointer-through-the-last-slave-anymor.patch

0001-dix-don-t-XWarpPointer-through-the-last-slave-anymor.patch (text/plain), 1.16 KB, created by Peter Hutterer on 2011-07-28 23:41:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2011-07-28 23:41:25 UTC

Size: 1.16 KB

patch

obsolete

>From 294f3c369d251c72e89e28ceab64354714e6f25d Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Fri, 29 Jul 2011 16:33:54 +1000
>Subject: [PATCH] dix: don''t XWarpPointer through the last slave anymore
> (#38313)
>
>This line was introduced pre-1.6 to fix Bug 19297. The effect of warping
>through the VCP then was that if a device had custom valuator ranges, the
>warp position would be wrong. This has since been fixed otherwise and
>devices scale the last valuators properly to and fro. Warp through the VCP
>(or whichever master pointer was selected).
>
>This fixes a server crash where the lastSlave is a pointer device without
>valuators (Bug 38313#0).
>
>X.Org Bug 38313 <http://bugs.freedesktop.org/show_bug.cgi?id=38313>
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> dix/events.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/dix/events.c b/dix/events.c
>index 25ff899..9efe8fb 100644
>--- a/dix/events.c
>+++ b/dix/events.c
>@@ -3446,8 +3446,6 @@ ProcWarpPointer(ClientPtr client)
> 	}
>     }
> 
>-    if (dev->lastSlave)
>-        dev = dev->lastSlave;
>     pSprite = dev->spriteInfo->sprite;
> 
> #ifdef PANORAMIX
>-- 
>1.7.6
>

Actions: View | Splinter Review

Attachments on bug 38313: 47968 | 49149 | 49702 | 49765 | 49766 | 57414 | 57415 | 57416

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.