Attachment 49922 Details for Bug 39836 – [PATCH 1/2] relay test: don't leak the server's address

[patch] [PATCH 1/2] relay test: don't leak the server's address

0001-relay-test-don-t-leak-the-server-s-address.patch (text/plain), 1.53 KB, created by Simon McVittie on 2011-08-04 09:09:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-08-04 09:09:04 UTC

Size: 1.53 KB

patch

obsolete

>From 66c22d79bce17ebc5af8e02e43a85f543493d5bb Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 4 Aug 2011 13:13:24 +0100
>Subject: [PATCH 1/2] relay test: don't leak the server's address
>
>---
> test/relay.c |   12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/test/relay.c b/test/relay.c
>index bad39f4..f4129d0 100644
>--- a/test/relay.c
>+++ b/test/relay.c
>@@ -137,12 +137,15 @@ test_connect (Fixture *f,
>     gconstpointer data G_GNUC_UNUSED)
> {
>   dbus_bool_t have_mem;
>+  char *address;
> 
>   g_assert (f->left_server_conn == NULL);
>   g_assert (f->right_server_conn == NULL);
> 
>-  f->left_client_conn = dbus_connection_open_private (
>-      dbus_server_get_address (f->server), &f->e);
>+  address = dbus_server_get_address (f->server);
>+  g_assert (address != NULL);
>+
>+  f->left_client_conn = dbus_connection_open_private (address, &f->e);
>   assert_no_error (&f->e);
>   g_assert (f->left_client_conn != NULL);
>   dbus_connection_setup_with_g_main (f->left_client_conn, NULL);
>@@ -153,12 +156,13 @@ test_connect (Fixture *f,
>       g_main_context_iteration (NULL, TRUE);
>     }
> 
>-  f->right_client_conn = dbus_connection_open_private (
>-      dbus_server_get_address (f->server), &f->e);
>+  f->right_client_conn = dbus_connection_open_private (address, &f->e);
>   assert_no_error (&f->e);
>   g_assert (f->right_client_conn != NULL);
>   dbus_connection_setup_with_g_main (f->right_client_conn, NULL);
> 
>+  dbus_free (address);
>+
>   while (f->right_server_conn == NULL)
>     {
>       g_print (".");

Actions: View | Splinter Review

Attachments on bug 39836: 49922 | 49923 | 49924

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.