Attachment 50635 Details for Bug 40437 – Add some debug about DRI2 failing and if a driver does not support DRI1

[patch] Add some debug about DRI2 failing and if a driver does not support DRI1

mesa-dri-debug-messages.diff (text/plain), 1.77 KB, created by Andrew Deason on 2011-08-28 11:33:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Deason

Created: 2011-08-28 11:33:36 UTC

Size: 1.77 KB

patch

obsolete

>From dd7e72d7883c63884f37020c38f89fa4e8ecc45c Mon Sep 17 00:00:00 2001
>From: Andrew Deason <adeason@dson.org>
>Date: Sun, 28 Aug 2011 11:46:02 -0500
>Subject: [PATCH 1/2] GLX: Say something if we cannot connect via DRI2
>
>---
> src/glx/dri2_glx.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
>index 80e4da3..1adea98 100644
>--- a/src/glx/dri2_glx.c
>+++ b/src/glx/dri2_glx.c
>@@ -832,6 +832,7 @@ dri2CreateScreen(int screen, struct glx_display * priv)
> 		    &driverName, &deviceName)) {
>       glx_screen_cleanup(&psc->base);
>       XFree(psc);
>+      InfoMessageF("screen %d does not appear to be DRI2 capable\n", screen);
>       return NULL;
>    }
> 
>-- 
>1.7.5.4
>
>
>From 12aeb060d1d924ba9b9da8cda1210b96f52ff234 Mon Sep 17 00:00:00 2001
>From: Andrew Deason <adeason@dson.org>
>Date: Sun, 28 Aug 2011 12:14:46 -0500
>Subject: [PATCH 2/2] DRI: Log something if we don't support legacy DRI
>
>If we are called via the legacy DRI interface, and we don't support
>legacy DRI (InitScreen is NULL), print a debug message, so it is easy
>to see why the driver fails to initialize.
>---
> src/mesa/drivers/dri/common/dri_util.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
>index 82638fa..725549b 100644
>--- a/src/mesa/drivers/dri/common/dri_util.c
>+++ b/src/mesa/drivers/dri/common/dri_util.c
>@@ -806,8 +806,10 @@ driCreateNewScreen(int scrn,
>     static const __DRIextension *emptyExtensionList[] = { NULL };
>     __DRIscreen *psp;
> 
>-    if (driDriverAPI.InitScreen == NULL)
>+    if (driDriverAPI.InitScreen == NULL) {
>+	__driUtilMessage("driver does not support DRI1");
> 	return NULL;
>+    }
> 
>     psp = calloc(1, sizeof *psp);
>     if (!psp)
>-- 
>1.7.5.4
>

Actions: View | Splinter Review

Attachments on bug 40437: 50635

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.