Attachment 50809 Details for Bug 40545 – mcd-account: use proper gboolean rather than 1 bit to store boolean properties

[patch] mcd-account: use proper gboolean rather than 1 bit to store boolean properties

mcd-account-use-proper-gboolean-rather-than-1-bit-.patch (text/plain), 1.23 KB, created by Guillaume Desmottes on 2011-09-01 05:27:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2011-09-01 05:27:43 UTC

Size: 1.23 KB

patch

obsolete

>From 4a46b19fd4a9e5e8ec6fb4b69451dc77b54b7609 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Thu, 1 Sep 2011 14:25:44 +0200
>Subject: [PATCH] mcd-account: use proper gboolean rather than 1 bit to store boolean properties
>
>It doesn't make sense to not use the boolean type provided by our framework
>and using 1 bit variable introduces weird corner case when being casted with
>gboolean.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=40545
>---
> src/mcd-account.c |   14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/src/mcd-account.c b/src/mcd-account.c
>index 1f3fff7..7935a36 100644
>--- a/src/mcd-account.c
>+++ b/src/mcd-account.c
>@@ -168,13 +168,13 @@ struct _McdAccountPrivate
>      */
>     GError *invalid_reason;
> 
>-    guint connect_automatically : 1;
>-    guint enabled : 1;
>-    guint loaded : 1;
>-    guint has_been_online : 1;
>-    guint removed : 1;
>-    guint always_on : 1;
>-    guint changing_presence : 1;
>+    gboolean connect_automatically;
>+    gboolean enabled;
>+    gboolean loaded;
>+    gboolean has_been_online;
>+    gboolean removed;
>+    gboolean always_on;
>+    gboolean changing_presence;
> 
>     gboolean hidden;
>     gboolean always_dispatch;
>-- 
>1.7.4.1

Actions: View | Splinter Review

Attachments on bug 40545: 50809

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.