Attachment 51394 Details for Bug 40701 – Fix for crash, but not broken feature

[patch] Fix for crash, but not broken feature

0002-FmXGridPeer-getByIndex-Error-checking-of-pGrid-GetMo.patch (text/plain), 1017 bytes, created by Lionel Elie Mamane on 2011-09-20 02:34:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lionel Elie Mamane

Created: 2011-09-20 02:34:02 UTC

Size: 1017 bytes

patch

obsolete

>From 43de7ca913a071a231cf6ca34ef3a609de498808 Mon Sep 17 00:00:00 2001
>From: Lionel Elie Mamane <lionel@mamane.lu>
>Date: Sun, 11 Sep 2011 23:40:09 +0200
>Subject: [PATCH 2/2] FmXGridPeer::getByIndex: Error checking of pGrid->GetModelColumnPos(nId) call
>
>Fixes crash of fdo#40701, but not broken feature
>---
> svx/source/fmcomp/fmgridif.cxx |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/svx/source/fmcomp/fmgridif.cxx b/svx/source/fmcomp/fmgridif.cxx
>index 3080d77..a4146a9 100644
>--- a/svx/source/fmcomp/fmgridif.cxx
>+++ b/svx/source/fmcomp/fmgridif.cxx
>@@ -2442,6 +2442,9 @@ Any FmXGridPeer::getByIndex(sal_Int32 _nIndex) throw( IndexOutOfBoundsException,
>     // get the list position
>     sal_uInt16 nPos = pGrid->GetModelColumnPos(nId);
> 
>+    if ( nPos == GRID_COLUMN_NOT_FOUND )
>+        return aElement;
>+
>     DbGridColumn* pCol = pGrid->GetColumns().at( nPos );
>     Reference< ::com::sun::star::awt::XControl >  xControl(pCol->GetCell());
>     aElement <<= xControl;
>-- 
>1.7.2.5
>

Actions: View | Splinter Review

Attachments on bug 40701: 50981 | 50987 | 51393 | 51394

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.