Attachment 52605 Details for Bug 23775 – limit the maximum pitch on the GD5446 to 4088

[patch] limit the maximum pitch on the GD5446 to 4088

cirrus_max_pitch.patch (text/plain), 1.23 KB, created by Stefan Potyra on 2011-10-20 11:52:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Potyra

Created: 2011-10-20 11:52:37 UTC

Size: 1.23 KB

patch

obsolete

>commit a7b98b31bd9a049c5990642f1b29f55ef90305ff
>Author: Stefan Potyra <sistpoty@ubuntu.com>
>Date:   Thu Oct 20 20:39:44 2011 +0200
>
>    Limit the maximum supported pitch of the GD5446 to 4088, since the internal
>    pitch register is only 9 bit (and contains the pitch left shifted by 3).
>
>diff --git a/src/alp_driver.c b/src/alp_driver.c
>index e773471..07fc1aa 100644
>--- a/src/alp_driver.c
>+++ b/src/alp_driver.c
>@@ -405,6 +405,8 @@ GetAccelPitchValues(ScrnInfoPtr pScrn)
> {
> 	int *linePitches = NULL;
> 	int i, n = 0;
>+	int max_pitch;
>+
> 	CirPtr pCir = CIRPTR(pScrn);
> 
> 	/* XXX ajv - 512, 576, and 1536 may not be supported
>@@ -421,8 +423,20 @@ GetAccelPitchValues(ScrnInfoPtr pScrn)
> 							1280, 1536, 1600, 1920, 2048, 0 };
> #endif
> 
>+	switch (pCir->Chipset) {
>+	case PCI_CHIP_GD5446:
>+		max_pitch = 0x1ff << 3;
>+		break;
>+
>+	default:
>+		/* FIXME max_pitch for other chipsets? */
>+		max_pitch = (pScrn->bitsPerPixel / 8) * 2048;
>+		break;
>+	}
>+
> 	for (i = 0; accelWidths[i] != 0; i++) {
>-		if (accelWidths[i] % pCir->Rounding == 0) {
>+		if ((accelWidths[i] % pCir->Rounding == 0)
>+		 && ((accelWidths[i] * pScrn->bitsPerPixel / 8) <= max_pitch)) {
> 			n++;
> 			linePitches = xnfrealloc(linePitches, n * sizeof(int));
> 			linePitches[n - 1] = accelWidths[i];

Actions: View | Splinter Review

Attachments on bug 23775: 29308 | 52605

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.