Attachment 53508 Details for Bug 42715 – Fix for src/pulsecore/mutex-posix.c

[patch] Fix for src/pulsecore/mutex-posix.c

0004-mutex-handle-gracefully-if-a-PTHREAD_PRIO_INHERIT-pr.patch (text/plain), 1.18 KB, created by Pino Toscano on 2011-11-14 03:24:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pino Toscano

Created: 2011-11-14 03:24:43 UTC

Size: 1.18 KB

patch

obsolete

>From f9783b9b6a1a79c80c6b4eba59062efbf2a4186d Mon Sep 17 00:00:00 2001
>From: Pino Toscano <toscano.pino@tiscali.it>
>Date: Mon, 14 Nov 2011 11:58:25 +0100
>Subject: [PATCH] mutex: handle gracefully if a PTHREAD_PRIO_INHERIT protocol
> cannot be set
>
>This adds an additional check for unavailable PTHREAD_PRIO_INHERIT to the
>fallback work done in ca717643ee768307475fc36ea29d920a13db0a8e
>
>See bug #42715
>---
> src/pulsecore/mutex-posix.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/src/pulsecore/mutex-posix.c b/src/pulsecore/mutex-posix.c
>index 634087d..5045af7 100644
>--- a/src/pulsecore/mutex-posix.c
>+++ b/src/pulsecore/mutex-posix.c
>@@ -50,8 +50,10 @@ pa_mutex* pa_mutex_new(pa_bool_t recursive, pa_bool_t inherit_priority) {
>         pa_assert_se(pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE) == 0);
> 
> #ifdef HAVE_PTHREAD_PRIO_INHERIT
>-    if (inherit_priority)
>-        pa_assert_se(pthread_mutexattr_setprotocol(&attr, PTHREAD_PRIO_INHERIT) == 0);
>+    if (inherit_priority) {
>+        r = pthread_mutexattr_setprotocol(&attr, PTHREAD_PRIO_INHERIT);
>+        pa_assert_se(r == 0 || r == ENOTSUP);
>+    }
> #endif
> 
>     m = pa_xnew(pa_mutex, 1);
>-- 
>1.7.7
>

Actions: View | Splinter Review

Attachments on bug 42715: 53298 | 53505 | 53506 | 53507 | 53508 | 53509 | 53510

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.