Attachment 53778 Details for Bug 9528 – Just removed the code which caused problems and everything started working

[patch] Just removed the code which caused problems and everything started working

patch (text/plain), 1.24 KB, created by Uli Schlachter on 2011-11-22 09:41:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Uli Schlachter

Created: 2011-11-22 09:41:36 UTC

Size: 1.24 KB

patch

obsolete

>diff --git a/src/xcb_io.c b/src/xcb_io.c
>index 0af47d8..168fd66 100644
>--- a/src/xcb_io.c
>+++ b/src/xcb_io.c
>@@ -604,28 +604,6 @@ Status _XReply(Display *dpy, xReply *rep, int extra, Bool discard)
> 		 * ignored those user locks in this case, so we do too. */
> 		InternalLockDisplay(dpy, /* ignore user locks */ 1);
> 
>-		/* We have the response we're looking for. Now, before
>-		 * letting anyone else process this sequence number, we
>-		 * need to process any events that should have come
>-		 * earlier. */
>-
>-		if(dpy->xcb->event_owner == XlibOwnsEventQueue)
>-		{
>-			xcb_generic_reply_t *event;
>-			/* If some thread is already waiting for events,
>-			 * it will get the first one. That thread must
>-			 * process that event before we can continue. */
>-			/* FIXME: That event might be after this reply,
>-			 * and might never even come--or there might be
>-			 * multiple threads trying to get events. */
>-			while(dpy->xcb->event_waiter)
>-			{ /* need braces around ConditionWait */
>-				ConditionWait(dpy, dpy->xcb->event_notify);
>-			}
>-			while((event = poll_for_event(dpy)))
>-				handle_response(dpy, event, True);
>-		}
>-
> 		req->reply_waiter = 0;
> 		ConditionBroadcast(dpy, dpy->xcb->reply_notify);
> 		if(XLIB_SEQUENCE_COMPARE(req->sequence, >, dpy->request)) {

Actions: View | Splinter Review

Attachments on bug 9528: 8283 | 53778

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.