Attachment 53955 Details for Bug 21442 – use wmb to flush the wc cache

[patch] use wmb to flush the wc cache

0001-drm-i915-properly-flush-the-wc-buffer-in-pwrites-to-.patch (text/plain), 977 bytes, created by Daniel Vetter on 2011-11-29 09:31:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2011-11-29 09:31:44 UTC

Size: 977 bytes

patch

obsolete

>From 3b66c0d60fe507534a739b6de0401bf92318feb2 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Tue, 29 Nov 2011 16:01:46 +0100
>Subject: [PATCH] drm/i915: properly flush the wc buffer in pwrites to phys
> objects
>
>Usually results in (rare) cursor corruptions on platforms
>requiring physically addressed cursors.
>
>Cc: stable@kernel.org
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35460
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=21442
>Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/i915_gem.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>index 39459d2..d560175 100644
>--- a/drivers/gpu/drm/i915/i915_gem.c
>+++ b/drivers/gpu/drm/i915/i915_gem.c
>@@ -4123,6 +4123,7 @@ i915_gem_phys_pwrite(struct drm_device *dev,
> 			return -EFAULT;
> 	}
> 
>+	wmb();
> 	intel_gtt_chipset_flush();
> 	return 0;
> }
>-- 
>1.7.7.1
>

Actions: View | Splinter Review

Attachments on bug 21442: 25201 | 25220 | 25221 | 25870 | 29049 | 53952 | 53955 | 61351

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.