Attachment 54070 Details for Bug 43416 – build: fix linking with -Wl,--as-needed -Wl,--no-undefined etc..

[patch] build: fix linking with -Wl,--as-needed -Wl,--no-undefined etc..

build-fix-linking-with--Wl--as-needed--Wl--no-unde.patch (text/plain), 1.60 KB, created by Marc-Andre Lureau on 2011-12-02 04:47:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc-Andre Lureau

Created: 2011-12-02 04:47:47 UTC

Size: 1.60 KB

patch

obsolete

>From 3debe437e5f92aed9c0a683cbf2466bf70ae9777 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
>Date: Fri, 2 Dec 2011 13:44:40 +0100
>Subject: [PATCH spice-gtk] build: fix linking with -Wl,--as-needed
> -Wl,--no-undefined etc..
>
>Mageia is using linker flags and miss symbols when linking.
>The error can be reproduced with:
>
>make LDFLAGS="-Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags"
>
>Based on patch by Christophe Fergeau.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=43416
>---
> configure.ac    |    2 +-
> gtk/Makefile.am |    1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 4a94d7b..6d06485 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -266,7 +266,7 @@ AC_SUBST(PULSE_CFLAGS)
> AC_SUBST(PULSE_LIBS)
> 
> AS_IF([test "x$with_audio" = "xgstreamer"],
>-      [PKG_CHECK_MODULES(GST, gstreamer-0.10 gstreamer-base-0.10 gstreamer-app-0.10, [have_gst=yes GST_LIBS="$GST_LIBS -lgstapp-0.10 -lgstaudio-0.10"], [have_gst=no])],
>+      [PKG_CHECK_MODULES(GST, gstreamer-0.10 gstreamer-base-0.10 gstreamer-app-0.10, [have_gst=yes GST_LIBS="$GST_LIBS -lgstapp-0.10 -lgstaudio-0.10 -lgstinterfaces-0.10"], [have_gst=no])],
>       [have_gst=no])
> 
> AS_IF([test "x$have_gst" = "xyes"],
>diff --git a/gtk/Makefile.am b/gtk/Makefile.am
>index 491eff8..b780882 100644
>--- a/gtk/Makefile.am
>+++ b/gtk/Makefile.am
>@@ -98,6 +98,7 @@ SPICE_GTK_LIBADD_COMMON =		\
> 	libspice-client-glib-2.0.la	\
> 	$(GTK_LIBS)			\
> 	$(CAIRO_LIBS)			\
>+	$(XRANDR_LIBS)			\
> 	$(NULL)
> 
> SPICE_GTK_SOURCES_COMMON =		\
>-- 
>1.7.7.3

Actions: View | Splinter Review

Attachments on bug 43416: 54005 | 54012 | 54014 | 54068 | 54070

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.