Attachment 5505 Details for Bug 5557 – patch for leak 1

[patch] patch for leak 1

mesa-5557.diff (text/plain), 1.07 KB, created by Tilman Sauerbeck on 2006-04-28 07:04:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tilman Sauerbeck

Created: 2006-04-28 07:04:40 UTC

Size: 1.07 KB

patch

obsolete

>Index: src/mesa/shader/arbprogparse.c
>===================================================================
>RCS file: /cvs/mesa/Mesa/src/mesa/shader/arbprogparse.c,v
>retrieving revision 1.57
>diff -u -p -r1.57 arbprogparse.c
>--- src/mesa/shader/arbprogparse.c	25 Apr 2006 00:21:32 -0000	1.57
>+++ src/mesa/shader/arbprogparse.c	27 Apr 2006 21:02:39 -0000
>@@ -3884,6 +3884,10 @@ _mesa_parse_arb_program(GLcontext *ctx, 
>       err = !grammar_check(grammar_syn_id, (byte *) arb_grammar_text,
>                            &parsed, &parsed_len);
> 
>+      /* 'parsed' is unused here */
>+      _mesa_free (parsed);
>+      parsed = NULL;
>+
>       /* NOTE: we can't destroy grammar_syn_id right here because
>        * grammar_destroy() can reset the last error
>        */
>@@ -3956,6 +3960,7 @@ _mesa_parse_arb_program(GLcontext *ctx, 
>    /* Syntax parse error */
>    if (err) {
>       _mesa_free(strz);
>+      _mesa_free(parsed);
>       grammar_get_last_error ((GLubyte *) error_msg, 300, &error_pos);
>       _mesa_set_program_error (ctx, error_pos, error_msg);
>       _mesa_error (ctx, GL_INVALID_OPERATION,

Actions: View | Splinter Review

Attachments on bug 5557: 5505 | 5506

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.