Attachment 55416 Details for Bug 43698 – Adjust vertex format swizzles to compensate for the vertex fetcher byte swap

[patch] Adjust vertex format swizzles to compensate for the vertex fetcher byte swap

fdo43698-vtxfmt-endianness.diff (text/plain), 1.17 KB, created by Michel Dänzer on 2012-01-11 03:31:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2012-01-11 03:31:14 UTC

Size: 1.17 KB

patch

obsolete

>diff --git a/src/gallium/drivers/r300/r300_state_inlines.h b/src/gallium/drivers/r300/r300_state_inlines.h
>index 62c03b3..fa2e458 100644
>--- a/src/gallium/drivers/r300/r300_state_inlines.h
>+++ b/src/gallium/drivers/r300/r300_state_inlines.h
>@@ -422,8 +422,24 @@ r300_translate_vertex_data_swizzle(enum pipe_format format) {
>     }
> 
>     for (i = 0; i < desc->nr_channels; i++) {
>-        swizzle |=
>-            MIN2(desc->swizzle[i], R300_SWIZZLE_SELECT_FP_ONE) << (3*i);
>+        unsigned channel_swizzle = MIN2(desc->swizzle[i], R300_SWIZZLE_SELECT_FP_ONE);
>+
>+#ifdef PIPE_ARCH_BIG_ENDIAN
>+	if (channel_swizzle < R300_SWIZZLE_SELECT_FP_ZERO) {
>+            /* Compensate for the vertex fetcher byte-swap */
>+            switch (desc->channel[i].size) {
>+                case 8:
>+                    assert(desc->nr_channels > 2);
>+                    channel_swizzle = R300_SWIZZLE_SELECT_W - channel_swizzle;
>+                    break;
>+                case 16:
>+                    channel_swizzle ^= 0x1;
>+                    break;
>+            }
>+        }
>+#endif
>+
>+        swizzle |= channel_swizzle << (3*i);
>     }
>     /* Set (0,0,0,1) in unused components. */
>     for (; i < 3; i++) {

Actions: View | Splinter Review

Attachments on bug 43698: 54298 | 54299 | 54300 | 54301 | 54302 | 54303 | 54304 | 54470 | 54516 | 55416 | 123755 | 124066

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.