Attachment 56684 Details for Bug 45710 – patch to drop the parameter

[patch] patch to drop the parameter

0001-drop-print-reply-from-dbus-send-command-used-on-susp.patch (text/plain), 1.42 KB, created by Adam Williamson on 2012-02-06 11:01:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Williamson

Created: 2012-02-06 11:01:47 UTC

Size: 1.42 KB

patch

obsolete

>From 4b581951ab412e9b2522d1ee57377d2102cabfc0 Mon Sep 17 00:00:00 2001
>From: Adam Williamson <awilliam@redhat.com>
>Date: Mon, 6 Feb 2012 10:57:54 -0800
>Subject: [PATCH] drop --print-reply from dbus-send command used on
> suspend/resume
>
>The dbus-send command used to refresh PK's caches over a suspend/resume cycle
>included the --print-reply parameter. This causes the command not to return
>until the dbus call either succeeds or fails - in the failure case, a delay of
>25 seconds (dbus' timeout) is possible. This blocks all later resume-time
>scripts, including the one that brings the network back up. Removing the
>parameter makes the PK call non-blocking, so the rest of the system resume can
>proceed even if it doesn't work immediately, eliminating the possibility of the
>network being down for 25 seconds at system resume.
>---
> contrib/pm-utils/95packagekit |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/contrib/pm-utils/95packagekit b/contrib/pm-utils/95packagekit
>index 407cd1a..73ed00c 100755
>--- a/contrib/pm-utils/95packagekit
>+++ b/contrib/pm-utils/95packagekit
>@@ -11,7 +11,7 @@ case "$1" in
> 	thaw|resume)
> 		# get PackageKit to invalidate its caches and get new updates
> 		dbus-send --system --dest=org.freedesktop.PackageKit \
>-			  --type=method_call --print-reply \
>+			  --type=method_call \
> 			  /org/freedesktop/PackageKit \
> 			  org.freedesktop.PackageKit.StateHasChanged \
> 			  string:'resume'
>-- 
>1.7.9
>

Actions: View | Splinter Review

Attachments on bug 45710: 56684

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.