Attachment 56796 Details for Bug 43171 – Always use the LVDS presence pin on PCH

[patch] Always use the LVDS presence pin on PCH

0001-drm-i915-lvds-Always-use-the-presence-pin-for-LVDS-o.patch (text/plain), 2.53 KB, created by Chris Wilson on 2012-02-09 01:35:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-02-09 01:35:57 UTC

Size: 2.53 KB

patch

obsolete

>From be90ea04ed09631f790ee07f323d7d7b96c5d9bf Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Thu, 9 Feb 2012 09:30:58 +0000
>Subject: [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH
>
>With the introduction of the PCH, we gained an LVDS presence pin but we
>continued to use the existing logic that asserted that LVDS was only
>supported on certain mobile chipsets. However, there are desktop
>IronLake systems with LVDS attached which we fail to detect. So for PCH,
>trust the LVDS presence pin and quirk all the lying manufacturers.
>
>Reported-by: Daniel Woff <wolff.daniel@gmail.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43171
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_display.c |    5 ++---
> drivers/gpu/drm/i915/intel_lvds.c    |   15 +++++++++++++++
> 2 files changed, 17 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index f02f86a..62bcbfd 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -7456,10 +7456,9 @@ static void intel_setup_outputs(struct drm_device *dev)
> 	struct drm_i915_private *dev_priv = dev->dev_private;
> 	struct intel_encoder *encoder;
> 	bool dpd_is_edp = false;
>-	bool has_lvds = false;
>+	bool has_lvds;
> 
>-	if (IS_MOBILE(dev) && !IS_I830(dev))
>-		has_lvds = intel_lvds_init(dev);
>+	has_lvds = intel_lvds_init(dev);
> 	if (!has_lvds && !HAS_PCH_SPLIT(dev)) {
> 		/* disable the panel fitter on everything but LVDS */
> 		I915_WRITE(PFIT_CONTROL, 0);
>diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
>index e441911..fff3886 100644
>--- a/drivers/gpu/drm/i915/intel_lvds.c
>+++ b/drivers/gpu/drm/i915/intel_lvds.c
>@@ -828,6 +828,18 @@ static bool lvds_is_present_in_vbt(struct drm_device *dev,
> 	return false;
> }
> 
>+static bool intel_lvds_supported(struct drm_device *dev)
>+{
>+	/* With the introduction of the PCH we gained a dedicated
>+	 * LVDS presence pin, use it. */
>+	if (HAS_PCH_SPLIT(dev))
>+		return true;
>+
>+	/* Otherwise LVDS was only attached to mobile products,
>+	 * except for the inglorious 830gm */
>+	return IS_MOBILE(dev) && !IS_I830(dev);
>+}
>+
> /**
>  * intel_lvds_init - setup LVDS connectors on this device
>  * @dev: drm device
>@@ -849,6 +861,9 @@ bool intel_lvds_init(struct drm_device *dev)
> 	int pipe;
> 	u8 pin;
> 
>+	if (!intel_lvds_supported(dev))
>+		return false;
>+
> 	/* Skip init on machines we know falsely report LVDS */
> 	if (dmi_check_system(intel_no_lvds))
> 		return false;
>-- 
>1.7.9
>

Actions: View | Splinter Review

Attachments on bug 43171: 53780 | 53781 | 53782 | 53783 | 53785 | 53786 | 56796

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.