Attachment 57345 Details for Bug 41648 – Suppress warning for MTRR allocation failure when using PAT

[patch] Suppress warning for MTRR allocation failure when using PAT

0001-drm-i915-Suppress-warning-for-MTRR-failure-if-PAT-is.patch (text/plain), 1.46 KB, created by Chris Wilson on 2012-02-20 11:19:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-02-20 11:19:03 UTC

Size: 1.46 KB

patch

obsolete

>From 94ece608774ba18638dd33402f67cad4de6f3715 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 20 Feb 2012 19:14:59 +0000
>Subject: [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is
> enabled
>
>Emitting a spurious warning about poor graphics performance when MTRR
>are irrelevant leads to confused users and useless bug reports.
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=41648
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/i915_dma.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
>index 716ba80..7a99d0c 100644
>--- a/drivers/gpu/drm/i915/i915_dma.c
>+++ b/drivers/gpu/drm/i915/i915_dma.c
>@@ -35,6 +35,7 @@
> #include "i915_drv.h"
> #include "i915_trace.h"
> #include "../../../platform/x86/intel_ips.h"
>+#include <asm/pat.h>
> #include <linux/pci.h>
> #include <linux/vgaarb.h>
> #include <linux/acpi.h>
>@@ -1998,10 +1999,9 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
> 	dev_priv->mm.gtt_mtrr = mtrr_add(dev->agp->base,
> 					 agp_size,
> 					 MTRR_TYPE_WRCOMB, 1);
>-	if (dev_priv->mm.gtt_mtrr < 0) {
>+	if (dev_priv->mm.gtt_mtrr < 0 && !pat_enabled)
> 		DRM_INFO("MTRR allocation failed.  Graphics "
> 			 "performance may suffer.\n");
>-	}
> 
> 	/* The i915 workqueue is primarily used for batched retirement of
> 	 * requests (and thus managing bo) once the task has been completed
>-- 
>1.7.9
>

Actions: View | Splinter Review

Attachments on bug 41648: 52174 | 52175 | 52176 | 52177 | 52178 | 52179 | 52180 | 52181 | 57345

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.