Attachment 57582 Details for Bug 45896 – _dbus_transport_new_for_tcp_socket: add missing commas to address

[patch] _dbus_transport_new_for_tcp_socket: add missing commas to address

0001-_dbus_transport_new_for_tcp_socket-add-missing-comma.patch (text/plain), 1.21 KB, created by Simon McVittie on 2012-02-24 03:25:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-02-24 03:25:55 UTC

Size: 1.21 KB

patch

obsolete

>From 3180bc13be3cb3fc5e626f6b3b8ce897fdcd52ea Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 24 Feb 2012 11:15:21 +0000
>Subject: [PATCH] _dbus_transport_new_for_tcp_socket: add missing commas to
> address
>
>Ralf pointed out that the address doesn't round-trip correctly.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45896
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> dbus/dbus-transport-socket.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/dbus/dbus-transport-socket.c b/dbus/dbus-transport-socket.c
>index 0673a8c..544d00a 100644
>--- a/dbus/dbus-transport-socket.c
>+++ b/dbus/dbus-transport-socket.c
>@@ -1337,12 +1337,12 @@ _dbus_transport_new_for_tcp_socket (const char     *host,
>     goto error;
> 
>   if (family != NULL &&
>-      (!_dbus_string_append (&address, "family=") ||
>+      (!_dbus_string_append (&address, ",family=") ||
>        !_dbus_string_append (&address, family)))
>     goto error;
> 
>   if (noncefile != NULL &&
>-      (!_dbus_string_append (&address, "noncefile=") ||
>+      (!_dbus_string_append (&address, ",noncefile=") ||
>        !_dbus_string_append (&address, noncefile)))
>     goto error;
> 
>-- 
>1.7.9.1
>

Actions: View | Splinter Review

Attachments on bug 45896: 56874 | 56875 | 57582

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.