Attachment 58340 Details for Bug 47247 – Fix disabling passwords

[patch] Fix disabling passwords

Fix-disabling-passwords.patch (text/plain), 1.05 KB, created by Bastien Nocera on 2012-03-12 11:51:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bastien Nocera

Created: 2012-03-12 11:51:33 UTC

Size: 1.05 KB

patch

obsolete

>From 039bc443373a1f30e632a0eeefc46f2d9f65296b Mon Sep 17 00:00:00 2001
>From: Bastien Nocera <hadess@hadess.net>
>Date: Mon, 12 Mar 2012 19:39:23 +0100
>Subject: [PATCH] Fix disabling passwords
>
>passwd requires root when "-d" is passed.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=47247
>---
> src/user.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/src/user.c b/src/user.c
>index 6cc54e1..9b2881a 100644
>--- a/src/user.c
>+++ b/src/user.c
>@@ -1357,7 +1357,8 @@ user_change_password_mode_authorized_cb (Daemon                *daemon,
>                         argv[4] = NULL;
> 
>                         error = NULL;
>-                        if (!spawn_with_login_uid (context, argv, &error)) {
>+                        /* the -d option requires root */
>+                        if (!spawn_with_uid (NULL, argv, &error)) {
>                                 throw_error (context, ERROR_FAILED, "running '%s' failed: %s", argv[0], error->message);
>                                 g_error_free (error);
>                                 return;
>-- 
>1.7.7.6

Actions: View | Splinter Review

Attachments on bug 47247: 58339 | 58340

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.