Attachment 58566 Details for Bug 47007 – Do not probe extensively if HPD hasn't changed on R600+ ASICs

[patch] Do not probe extensively if HPD hasn't changed on R600+ ASICs

0001-On-a-system-with-one-HDMI-and-one-VGA-connector-the-.patch (text/plain), 2.58 KB, created by Tvrtko Ursulin on 2012-03-16 08:09:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tvrtko Ursulin

Created: 2012-03-16 08:09:09 UTC

Size: 2.58 KB

patch

obsolete

>From 2d55d7b0341d7f1e7fb9ee44636e535276e03fa0 Mon Sep 17 00:00:00 2001
>From: Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk>
>Date: Fri, 16 Mar 2012 15:04:08 +0000
>Subject: [PATCH] On a system with one HDMI and one VGA connector the latter
> causes output polling to run every ten seconds. This causes
> full EDID re- fetch on every poll and approx. 100ms
> rendering stalls are experienced by full screen
> page-flipping applications. Optimisation is to trust HPD
> sense on R600+ ASICs and to skip doing these expensive
> probes unless HPD sense has changed.
>
>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk>
>---
> drivers/gpu/drm/radeon/radeon_connectors.c |   28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
>index 8b3d8ed..26890db 100644
>--- a/drivers/gpu/drm/radeon/radeon_connectors.c
>+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
>@@ -827,6 +827,28 @@ static int radeon_dvi_get_modes(struct drm_connector *connector)
> 	return ret;
> }
> 
>+static bool radeon_check_hpd_status_unchanged(struct drm_connector *connector)
>+{
>+	struct drm_device *dev = connector->dev;
>+	struct radeon_device *rdev = dev->dev_private;
>+	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
>+	enum drm_connector_status status;
>+
>+	/* We only trust HPD on R600 and newer ASICS. */
>+	if (rdev->family >= CHIP_R600
>+	  && radeon_connector->hpd.hpd != RADEON_HPD_NONE) {
>+		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd))
>+			status = connector_status_connected;
>+		else
>+			status = connector_status_disconnected;
>+    
>+		if (connector->status == status)
>+			return true;
>+	}
>+
>+	return false;
>+}
>+
> /*
>  * DVI is complicated
>  * Do a DDC probe, if DDC probe passes, get the full EDID so
>@@ -851,6 +873,9 @@ radeon_dvi_detect(struct drm_connector *connector, bool force)
> 	enum drm_connector_status ret = connector_status_disconnected;
> 	bool dret = false;
> 
>+	if (!force && radeon_check_hpd_status_unchanged(connector))
>+		return connector->status;
>+
> 	if (radeon_connector->ddc_bus)
> 		dret = radeon_ddc_probe(radeon_connector);
> 	if (dret) {
>@@ -1250,6 +1275,9 @@ radeon_dp_detect(struct drm_connector *connector, bool force)
> 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
> 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
> 
>+	if (!force && radeon_check_hpd_status_unchanged(connector))
>+		return connector->status;
>+
> 	if (radeon_connector->edid) {
> 		kfree(radeon_connector->edid);
> 		radeon_connector->edid = NULL;
>-- 
>1.7.6.4
>

Actions: View | Splinter Review

Attachments on bug 47007: 58063 | 58064 | 58160 | 58318 | 58360 | 58481 | 58515 | 58554 | 58555 | 58556 | 58566 | 58568

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.