Attachment 59083 Details for Bug 38138 – Clip the clear of the right-hand margin.

[patch] Clip the clear of the right-hand margin.

0001-video-console-Clip-the-right-margin-clear-to-the-vis.patch (text/plain), 1.33 KB, created by Chris Wilson on 2012-03-26 11:20:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-03-26 11:20:17 UTC

Size: 1.33 KB

patch

obsolete

>From a4952f60895d5d8bd1e03c3f9b204a83c363ae81 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 26 Mar 2012 19:13:18 +0100
>Subject: [PATCH] video/console: Clip the right margin clear to the visible
> region
>
>For some unknown reason, yres_virtual was 2x larger the the size specified
>by i915 and so when blit_clear_margins() tried to clear the full virtual
>right-hand margin it tried to write far beyond the end of the buffer.
>
>This limits the clear to only the visible portion of the right-hand
>margin, similar to how the bottom margin is treated.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38138
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/video/console/bitblit.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/video/console/bitblit.c b/drivers/video/console/bitblit.c
>index 28b1a83..9f89e5a 100644
>--- a/drivers/video/console/bitblit.c
>+++ b/drivers/video/console/bitblit.c
>@@ -219,9 +219,9 @@ static void bit_clear_margins(struct vc_data *vc, struct fb_info *info,
> 
> 	if (rw && !bottom_only) {
> 		region.dx = info->var.xoffset + rs;
>-		region.dy = 0;
>+		region.dy = info->var.yoffset;
> 		region.width = rw;
>-		region.height = info->var.yres_virtual;
>+		region.height = info->var.yres;
> 		info->fbops->fb_fillrect(info, &region);
> 	}
> 
>-- 
>1.7.9.1
>

Actions: View | Splinter Review

Attachments on bug 38138: 48933 | 59083 | 59090

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.